-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create DiscoverEC2 User Tasks when Auto Discover fails on EC2 instances #47064
Open
marcoandredinis
wants to merge
1
commit into
master
Choose a base branch
from
marco/discovery_emit_discoverec2_tasks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+401
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v16
labels
Oct 1, 2024
marcoandredinis
force-pushed
the
marco/discover_ec2_tasks
branch
from
October 2, 2024 08:08
4e32211
to
873c321
Compare
marcoandredinis
force-pushed
the
marco/discovery_emit_discoverec2_tasks
branch
from
October 2, 2024 08:08
ccff419
to
7567361
Compare
marcoandredinis
force-pushed
the
marco/discover_ec2_tasks
branch
from
October 2, 2024 13:23
873c321
to
5e20588
Compare
marcoandredinis
force-pushed
the
marco/discovery_emit_discoverec2_tasks
branch
from
October 2, 2024 13:42
7567361
to
0c450ad
Compare
marcoandredinis
force-pushed
the
marco/discover_ec2_tasks
branch
from
October 3, 2024 16:37
5e20588
to
497f0aa
Compare
marcoandredinis
force-pushed
the
marco/discovery_emit_discoverec2_tasks
branch
2 times, most recently
from
October 3, 2024 17:22
17cf648
to
c10e937
Compare
(i'm working on the flaky test but this should be reviewable already 👍 ) |
marcoandredinis
force-pushed
the
marco/discover_ec2_tasks
branch
from
October 4, 2024 10:11
497f0aa
to
649c8be
Compare
marcoandredinis
force-pushed
the
marco/discovery_emit_discoverec2_tasks
branch
2 times, most recently
from
October 4, 2024 10:30
bdb1723
to
3eb2db8
Compare
marcoandredinis
force-pushed
the
marco/discover_ec2_tasks
branch
from
October 4, 2024 10:31
649c8be
to
43cbfc1
Compare
marcoandredinis
force-pushed
the
marco/discovery_emit_discoverec2_tasks
branch
from
October 4, 2024 10:45
3eb2db8
to
a5b14d9
Compare
marcoandredinis
force-pushed
the
marco/discovery_emit_discoverec2_tasks
branch
from
October 4, 2024 11:32
a5b14d9
to
c1e1f45
Compare
This PR changes the DiscoveryService to start creating and updating Discover EC2 User Tasks. So, what are Discover EC2 User Tasks? When users set up Auto Discover for EC2 Instances, they don't have a good way of checking for issues on their configured matchers. We created User Tasks as a way to warn Users that something's wrong. Each User Task should describe an issue that happened and a way to fix it. This has potential to be used to report unexpected events trough the whole system, which are not errors per se, but something the user should take action in order to improve the situation. In this case, we are creating a sub type of those tasks: DiscoverEC2. From now on, when the DiscoveryService fails to auto-enroll an instance, it will create a DiscoverEC2 User Task grouping all the failed instances by the following props: - integration - issue type - account id - region A follow up PR will also create notifications so that the user can actually be notified on those User Tasks and take action.
marcoandredinis
force-pushed
the
marco/discovery_emit_discoverec2_tasks
branch
from
October 4, 2024 14:48
c1e1f45
to
6c641a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v16
discovery
no-changelog
Indicates that a PR does not require a changelog entry
size/md
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the DiscoveryService to start creating and updating
Discover EC2 User Tasks.
So, what are Discover EC2 User Tasks?
When users set up Auto Discover for EC2 Instances, they don't have a
good way of checking for issues on their configured matchers.
We created User Tasks as a way to warn Users that something's wrong.
Each User Task should describe an issue that happened and a way to fix
it.
This has potential to be used to report unexpected events trough the
whole system, which are not errors per se, but something the user should
take action in order to improve the situation.
In this case, we are creating a sub type of those tasks: DiscoverEC2.
From now on, when the DiscoveryService fails to auto-enroll an instance,
it will create a DiscoverEC2 User Task grouping all the failed instances
by the following props:
A follow up PR will also create notifications so that the user can
actually be notified on those User Tasks and take action.
Demo: