display security group id rules #47152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinFrazar
added
ui
discover
GavinFrazar
force-pushed
the
gavinfrazar/display-id-based-security-group-rules
branch
2 times, most recently
from
5043eb4
to
1d84069
Compare
kimlisa
approved these changes
Oct 3, 2024
greedy52
approved these changes
Oct 4, 2024
GavinFrazar
force-pushed
the
gavinfrazar/display-id-based-security-group-rules
branch
from
1d84069
to
901fb86
Compare
GavinFrazar
deleted the
gavinfrazar/display-id-based-security-group-rules
branch
|
@GavinFrazar See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fixed a bug where security group rules that refer to another security group by ID were not displayed in web UI enrollment wizards when viewing security group rules.
Closes #46620
This PR makes it so the security rule dialog correctly populates the rules that are based on security group ID rather than IP ranges. It also fixes the table style to truncate long descriptions since those can be up to 255 characters long - you can still see the full description by hovering over the text though.
Before
After