Add second_Factors
#47233
Open
Add second_Factors
#47233
+2,416
−2,120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
force-pushed
the
joerger/add-second-factors
branch
from
3e32b81
to
d536667
Compare
Joerger
commented
Oct 4, 2024
| // IsSecondFactorEnforced checks if second factor is enforced | ||
| // (not disabled or set to optional). | ||
| // IsSecondFactorEnabled checks if second factor is enabled. | ||
| IsSecondFactorEnabled() bool |
There was a problem hiding this comment.
note: this will be used in the follow up PR, but I'd rather add it here with these changes.
Joerger
force-pushed
the
joerger/add-second-factors
branch
from
d536667
to
cd71433
Compare
Joerger
force-pushed
the
joerger/add-second-factors
branch
from
cd71433
to
10c8b33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
second_factorsand prefer it oversecond_factor.We don't currently plan on removing second_factor, as this would require a more complicated migration process. Instead we will just derive
second_factorsfromsecond_factor(and vice versa) and output a warning log whensecond_factoris set.There is no plan to deprecate
second_factorcompletely. Whensecond_factoris set andsecond_factorsis not, or vice versa, we convert from one to the other.In a follow up PR I will update as much logic as possible to use
second_factorsinstead ofsecond_factor, as they are two sources of the same information.In this PR I've also added the SSO second_factor type. It is currently completely unused, but we'd rather get the proto changes into v17 rather than waiting until SSO MFA is fully released in a minor version.
Follow up TODO: Update docs.
Changelog: Add new second_factors field to cluster auth preference for more clarity and granularity over which 2fa methods are enabled in a cluster.
Depends on #47230