Allow websocket connections to the same host (csp) in Safari #7929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-kovoy
requested review from
klizhentas,
r0mant and
russjones
as code owners
r0mant
approved these changes
Aug 17, 2021
alex-kovoy
added a commit
that referenced
this pull request
Aug 20, 2021
alex-kovoy
added a commit
that referenced
this pull request
Sep 17, 2021
Co-authored-by: Roman Tkachenko <[email protected]>
zmb3
pushed a commit
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we extended our CSP headers with
default: 'self', the websockets connections stopped being allowed in Safari. This is becauseconnect-src 'self'does not resolve to websocket schemas in all browsers. More in it here.Fixes #7928