OIDC Claims Refactoring #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russjones
force-pushed
the
rjones/oidc-debugging
branch
from
f253191
to
8259a03
Compare
fallback to Base64 decoding if Base64-URL decoding fails.
russjones
force-pushed
the
rjones/oidc-debugging
branch
from
6f89850
to
c795689
Compare
klizhentas
approved these changes
Mar 31, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Not all services that support OIDC return all claims within the ID token, some services return claims from the
UserInfoendpoint. This PR changes the behavior of Teleport to obtain claims from both endpoints and merge them.Implementation
In
ValidateOIDCAuthCallback, extract claims from both the ID token as well as theUserInfoendpoint (which is itself obtained from theProviderConfig) and then merge the two sets of claims and return the merged set.