Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export html parts renderers #38

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Conversation

Volodomor
Copy link
Contributor

Pull Request for RFC gravity-ui/rfc#7

@Volodomor Volodomor force-pushed the export-html-parts-renderers branch 3 times, most recently from 67de491 to 1f00e7f Compare March 4, 2024 09:59
@obenjiro
Copy link

obenjiro commented Mar 4, 2024

@korvin89 @ValeraS @sofiushko

I would appreciate it if you could take some time to review this pull request. Thank you.

@Volodomor Volodomor force-pushed the export-html-parts-renderers branch from 1f00e7f to 2cadc5d Compare March 5, 2024 07:30
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/utils/generateRenderContent.ts Outdated Show resolved Hide resolved
src/utils/renderBodyContent.ts Outdated Show resolved Hide resolved
src/utils/generateRenderContent.ts Show resolved Hide resolved
README.md Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
src/utils/renderHeadContent.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
@Volodomor
Copy link
Contributor Author

@ValeraS Я поправил все замечания. Есть еще что-то?

src/types.ts Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Volodomor
Copy link
Contributor Author

@ValeraS done

src/render.ts Outdated Show resolved Hide resolved
@Volodomor Volodomor merged commit f5fee5e into main Mar 19, 2024
2 checks passed
@Volodomor Volodomor deleted the export-html-parts-renderers branch March 19, 2024 14:57
@Volodomor
Copy link
Contributor Author

@ValeraS выпусти, пожалуйста, новую версию

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants