feat(LayoutPlugin): allow to set and pass crossOrigin for styles and scripts #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValeraS
requested changes
Sep 16, 2024
| @@ -65,13 +65,14 @@ export function createLayoutPlugin({ | |||
| ...jsAssets.map((js) => ({ | |||
| src: getAbsoluteUrl(publicPath, js, options?.prefix), | |||
| defer: true, | |||
| crossOrigin: 'anonymous' as const, | |||
| crossOrigin: options.scriptsCrossOrigin || 'anonymous', | |||
There was a problem hiding this comment.
This only allows you to change the default to "use-credentials", right?
There was a problem hiding this comment.
Yes. I left "anonymous" as default. But for consistency added scriptsCrossOrigin as possible option.
| @@ -65,13 +65,14 @@ export function createLayoutPlugin({ | |||
| ...jsAssets.map((js) => ({ | |||
| src: getAbsoluteUrl(publicPath, js, options?.prefix), | |||
| defer: true, | |||
| crossOrigin: 'anonymous' as const, | |||
| crossOrigin: options.scriptsCrossOrigin || 'anonymous', | |||
There was a problem hiding this comment.
What about using crossOrigin from options in other places?
There was a problem hiding this comment.
I don't know where else crossOrigin may be needed. We encountered situation, that we need it only for stylesheets.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok, fair enough, i've added the same settings for this case
ValeraS
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is to pass crossOrigin from plugin options to scripts and styles.