feat(DateField): add component's description in README #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
Arucard89
force-pushed
the
DATAUI-2000
branch
from
579f4f1
to
37c81ba
Compare
korvin89
reviewed
Jan 25, 2024
src/components/DateField/README.md
Outdated
| | aria-labelledby | The control's `aria-labelledby` attribute | `string` | | | ||
| | autoFocus | The control's `autofocus` attribute | `boolean` | | | ||
| | className | The control's wrapper class name | `string` | | | ||
| | defaultValue | The control's default value, used when the component is not controlled | `DateTime` | | |
There was a problem hiding this comment.
This property used to set initial value in case of uncontrolled using. But it is not required
There was a problem hiding this comment.
There is no need in "Optional" word here, because we have column with this information
src/components/DateField/README.md
Outdated
| | rightContent | User`s node rendered after the input node and clear button | `React.ReactNode` | | | ||
| | size | The size of the control | `"s"` `"m"` `"l"` `"xl"` | `"m"` | | ||
| | style | Sets inline style for the element. | `CSSProperties` | | | ||
| | timeZone | Sets the time zone | `string` | | |
There was a problem hiding this comment.
It would be great if we add some link with all timezones and their formats
There was a problem hiding this comment.
Could u add this link here?
Arucard89
force-pushed
the
DATAUI-2000
branch
from
c16648a
to
d9a73be
Compare
|
Made all fixes |
Arucard89
force-pushed
the
DATAUI-2000
branch
from
0a2ed0e
to
d643a25
Compare
korvin89
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DATAUI-2000