-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DateField): add component's description in README #35
Conversation
Preview is ready. |
579f4f1
to
37c81ba
Compare
src/components/DateField/README.md
Outdated
| aria-labelledby | The control's `aria-labelledby` attribute | `string` | | | ||
| autoFocus | The control's `autofocus` attribute | `boolean` | | | ||
| className | The control's wrapper class name | `string` | | | ||
| defaultValue | The control's default value, used when the component is not controlled | `DateTime` | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property used to set initial value in case of uncontrolled using. But it is not required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need in "Optional" word here, because we have column with this information
src/components/DateField/README.md
Outdated
| rightContent | User`s node rendered after the input node and clear button | `React.ReactNode` | | | ||
| size | The size of the control | `"s"` `"m"` `"l"` `"xl"` | `"m"` | | ||
| style | Sets inline style for the element. | `CSSProperties` | | | ||
| timeZone | Sets the time zone | `string` | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we add some link with all timezones and their formats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could u add this link here?
c16648a
to
d9a73be
Compare
Made all fixes |
0a2ed0e
to
d643a25
Compare
DATAUI-2000