feat: add date picker string type #205
Conversation
|
Preview is ready. |
|
Playwright Test Component is ready. |
| const onUpdate = useCallback((date: DateTime | null) => { | ||
| if (!date) { | ||
| onChange(''); | ||
| } else if (spec.viewSpec.dateInput?.outputFormat) { |
There was a problem hiding this comment.
The data output format does not change
Uploading Screen Recording 2024-06-28 at 09.43.43.mov…
src/stories/Editor.stories.tsx
Outdated
| dateInput: { | ||
| outputFormat: 'YYYY-MM-DD', | ||
| }, | ||
| inputProps: { |
There was a problem hiding this comment.
let's get rid of TC ignore and remove inputProps: {
| 'maximum', | ||
| 'minimum', | ||
| 'format', | ||
| 'enum', |
There was a problem hiding this comment.
let's remove the input props
| qa: name, | ||
| }; | ||
|
|
||
| return <DatePicker {...props} />; |
There was a problem hiding this comment.
Screen.Recording.2024-06-28.at.09.43.43.mov
input jumps
| | Property | Type | Required | Description | | ||
| | :----------- | :------- | :------: | :-------------------------------------------------------------------------------------- | | ||
| | outputFormat | `string` | | Format returning string. [Available formats](https://day.js.org/docs/en/display/format) | | ||
|
|
There was a problem hiding this comment.
We also forgot to add a description here that there is such a possibility
https://github.com/gravity-ui/dynamic-forms/blob/add-date-picker/docs/spec.md#stringspec
| | Property | Type | Required | Description | | ||
| | :----------- | :------- | :------: | :-------------------------------------------------------------------------------------- | | ||
| | outputFormat | `string` | | Format returning string. [Available formats](https://day.js.org/docs/en/display/format) | | ||
|
|
There was a problem hiding this comment.
I think there are two formats needed here, one format that is waiting for the backend, the second format is the one in which we will display the date to the user
It is worth considering that the backend can wait for a millisecond string or a timestamp object, I did not see it here https://day.js.org/docs/en/display/format
No description provided.