feat(TimeRangeSelector): added new input Time Range Selector #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Playwright Test Component is ready. |
bocembocem
requested changes
Aug 9, 2024
| return times.filter(({value: time}) => time > cutoff); | ||
| } | ||
|
|
||
| return times.filter(({value: time}) => time < cutoff); |
There was a problem hiding this comment.
let's remove the code duplication
just like that
return times.filter(({value: time}) => direction === 'greater' ? time > cutoff : time < cutoff)
| import {ObjectIndependentView, ViewController, isStringSpec} from '../../../../core'; | ||
|
|
||
| const START_TIME = 'start'; | ||
| const END_TIME = 'end'; |
There was a problem hiding this comment.
I have seen similar constants in TimeRangeSelector 👀
|
|
||
| _spec.viewSpec.layout = 'row'; | ||
|
|
||
| endTimeSpec = _spec; |
There was a problem hiding this comment.
code is duplicated
let's do something like this
const [startTimeSpec, endTimeSpec] = [START_TIME, END_TIME].map((key) => {
if (spec.properties?.[key] && isStringSpec(spec.properties[key])) {
const spec = cloneDeep(spec.properties[key]);
spec.viewSpec.layout = 'row';
return spec;
}
return;
});
|
|
||
| if (input.value?.[END_TIME] && isString(input.value[END_TIME])) { | ||
| startTimeOptions = filterTimeArray(defaultTimeOptions, input.value[END_TIME], 'less'); | ||
| } |
There was a problem hiding this comment.
same comment about duplication
| const _spec = cloneDeep(spec.properties[END_TIME]); | ||
|
|
||
| endTimeSpec = _spec; | ||
| } |
There was a problem hiding this comment.
same comment about duplication
bocembocem
requested changes
Aug 9, 2024
| const property = spec.properties?.[key]; | ||
|
|
||
| if (isStringSpec(property)) { | ||
| const _spec = cloneDeep(property); |
There was a problem hiding this comment.
you have no reason to clone this spec
it looks like this memo might be like this
const [startTimeSpec, endTimeSpec] = React.useMemo(() =>
[START_TIME, END_TIME].map(
(key) => isStringSpec(spec.properties?.[key]) ? spec.properties?.[key] : undefined)
, [spec.properties]);
bocembocem
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.