fix(PM): close with timeout #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iapolya
force-pushed
the
fix-close-with-timeout
branch
from
4aa404f
to
c9db7db
Compare
vanilla-wave
reviewed
Oct 9, 2024
| @@ -203,8 +203,6 @@ export class Controller { | |||
| this.stateActions.removeFromQueue(slug); | |||
|
|
|||
| this.updateProgressInfo(slug); | |||
|
|
|||
| this.triggerNextPromo(); | |||
There was a problem hiding this comment.
This change dont break/fix any test. Can we add test for this?
There was a problem hiding this comment.
No, this change breaks 8 tests for callback validation controller.subscribe(callback). They are corrected by emitChange calls here. triggerNextPromo is also called in this function
There was a problem hiding this comment.
Maybe we should make closePromoWithTimeout async and await result?
There was a problem hiding this comment.
We still need to call addPromoToFinished and removeFromQueue before await result. It's unnecessary here
iapolya
force-pushed
the
fix-close-with-timeout
branch
from
0b0276d
to
3e4e4de
Compare
vanilla-wave
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.