feat(Alert): added ability to pass null as icon prop value

gravity-ui · Mar 6, 2024 · 78422eb · 78422eb
1 parent 8a57f91
commit 78422eb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/components/Alert/Alert.tsx b/src/components/Alert/Alert.tsx
@@ -40,7 +40,11 @@ export const Alert = (props: AlertProps) => {
                 qa={qa}
             >
                 <Flex gap="3" alignItems={align}>
-                    {props.icon || <Alert.Icon theme={theme} view={view} />}
+                    {typeof props.icon === 'undefined' ? (
+                        <Alert.Icon theme={theme} view={view} />
+                    ) : (
+                        props.icon // ability to pass `null` as `icon` prop value
+                    )}
                     <Flex direction={layout === 'vertical' ? 'column' : 'row'} gap="5" grow>
                         <Flex gap="2" grow className={bAlert('text-content')}>
                             <Flex direction="column" gap="1" grow justifyContent={align}>

diff --git a/src/components/Alert/__stories__/Alert.stories.tsx b/src/components/Alert/__stories__/Alert.stories.tsx
@@ -112,6 +112,13 @@ const stories: AlertProps[] = [
         theme: 'utility',
         view: 'filled',
     },
+    {
+        title,
+        message,
+        icon: null,
+        theme: 'utility',
+        view: 'filled',
+    },
     {
         message,
         theme: 'normal',