-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove popup wrapper class, use content classes for popover… #711
Conversation
Preview is ready. |
src/components/Popup/Popup.scss
Outdated
// Can be overridden, see Tooltip | ||
--yc-popup-background-color: var(--yc-color-base-float); | ||
--yc-popup-border-color: var(--yc-color-line-solid); | ||
--yc-popup-border-width: 1px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These variables should remain on the root node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They left at same level as it was. Do we need to move it up inside #{$block}{} declaration, or what are the changes needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved it up to #{$block}
src/components/Tooltip/Tooltip.tsx
Outdated
@@ -15,6 +15,7 @@ export interface TooltipProps extends TooltipDelayProps { | |||
children: React.ReactElement; | |||
className?: string; | |||
contentClassName?: string; | |||
popupContentClassName?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually need this? We already have className for Tooltip's content itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was added for backward ability to customize popup content because previously popup className was used for it (content) but now popup className is used for top-level elem (wrapper). Guess we can omit due to major, I've removed.
d5fdf40
to
93e4089
Compare
…s and tooltips
BREAKING CHANGE
Connected with #656 and further discussion.