refactor!: remove popup wrapper class, use content classes for popover… #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helenjer
requested review from
amje,
kseniya57,
ValeraS and
korvin89
as code owners
|
Preview is ready. |
amje
requested changes
Jun 20, 2023
src/components/Popup/Popup.scss
Outdated
| // Can be overridden, see Tooltip | ||
| --yc-popup-background-color: var(--yc-color-base-float); | ||
| --yc-popup-border-color: var(--yc-color-line-solid); | ||
| --yc-popup-border-width: 1px; |
There was a problem hiding this comment.
These variables should remain on the root node
There was a problem hiding this comment.
They left at same level as it was. Do we need to move it up inside #{$block}{} declaration, or what are the changes needed?
There was a problem hiding this comment.
I've moved it up to #{$block}
src/components/Tooltip/Tooltip.tsx
Outdated
| @@ -15,6 +15,7 @@ export interface TooltipProps extends TooltipDelayProps { | |||
| children: React.ReactElement; | |||
| className?: string; | |||
| contentClassName?: string; | |||
| popupContentClassName?: string; | |||
There was a problem hiding this comment.
Do we actually need this? We already have className for Tooltip's content itself
There was a problem hiding this comment.
It was added for backward ability to customize popup content because previously popup className was used for it (content) but now popup className is used for top-level elem (wrapper). Guess we can omit due to major, I've removed.
amje
requested review from
ogonkov,
sofiushko,
krozhkov,
DarkGenius,
Avol-V,
mfyodorov,
DaffPunks,
goshander,
axtk,
Volodomor,
vrozaev and
Marginy605
as code owners
helenjer
force-pushed
the
refactor_popup_classes
branch
from
d5fdf40
to
93e4089
Compare
amje
approved these changes
Jun 29, 2023
amje
pushed a commit
that referenced
this pull request
Jul 10, 2023
amje
pushed a commit
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s and tooltips
BREAKING CHANGE
Connected with #656 and further discussion.