Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(List): extend emptyPlaceholder type to ReactNode #1013

Merged
merged 2 commits into from
Oct 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/List/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ Likewise, you can forward `onFocus` and `onBlur` if you need to repeat the behav
| filterClassName | Class for filter input styles | `String` | |
| onChangeFilter | Filter change handler (if external sorting is used). `(filter: string) => void` | `Function` | |
| onFilterEnd | Function invoked after internal filtering is completed. `({items}: {items: T[]}) => void` | `Function` | |
| emptyPlaceholder | Placeholder for an empty list. | `String` | |
| emptyPlaceholder | Placeholder for an empty list. | `React.ReactNode` | |
| sortable | Flag that enables list sorting. | `Boolean` | |
| sortHandleAlign | Sorting indicator alignment (left or right). | `left` `right` | |
| onSortEnd | Sorting event handler. `({oldIndex: number, newIndex: number}) => void` | `Function` | |
Expand Down
2 changes: 1 addition & 1 deletion src/components/List/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export type ListProps<T = unknown> = QAProps & {
itemClassName?: string;
itemsClassName?: string;
filterClassName?: string;
emptyPlaceholder?: string;
emptyPlaceholder?: React.ReactNode;
filterPlaceholder?: string;
filter?: string;
activeItemIndex?: number;
Expand Down
Loading