-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor hooks useEventBroker and useLayer #1060
Conversation
Preview is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About naming: we are trying to use kebab-case for folders and files except react component files naming that uses camel case. Could u rename utils/eventBroker
-> utils/event-broker
?
51ccbb8
to
17553c7
Compare
done |
export type { | ||
LayerConfig, | ||
LayerExtendableProps, | ||
ContentElement, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we want LayerExtendableProps and ContentElement to be exposed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
a7281d4
to
a71a795
Compare
Hook
useEventBroker
anduseLayer
very connected with their classes, therefore, there was no point in taking them out separately. Instead, I refactored folder for these utilities