fix(Icon): correct prepareStringData #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
ogonkov
reviewed
Nov 7, 2023
| it('should remove width and height only inside svg tag', () => { | ||
| const data = | ||
| '<svg width="100" viewBox="0 0 200 200" height="200">\n<rect x="50" y="50" width="100" height="100" fill="red" />\n</svg>'; | ||
| expect(prepareStringData(data)).toEqual( |
There was a problem hiding this comment.
.toBe is more straightforward
There was a problem hiding this comment.
.toBe is specifically useful for reference equality, for string comparison there is no difference here
korvin89
approved these changes
Nov 7, 2023
amje
requested changes
Nov 7, 2023
| @@ -22,7 +22,12 @@ export function isStringSvgData(data: SVGIconData): data is SVGIconStringData { | |||
| return typeof data === 'string'; | |||
| } | |||
| export function prepareStringData(data: SVGIconStringData) { | |||
| return data.replace(/(width|height)=(["']?)\d+\2/g, ''); | |||
There was a problem hiding this comment.
We should keep the same logic for quotes
amje
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.