Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test): replace Enzyme with React Testing Library #157

Merged
merged 1 commit into from
May 11, 2022
Merged

feat(test): replace Enzyme with React Testing Library #157

merged 1 commit into from
May 11, 2022

Conversation

helenjer
Copy link
Contributor

@helenjer helenjer commented May 9, 2022

Enzyme is weakly maintained now:

  • no package updates for 2+ years;
  • no official support for React 17.

React Testing Library is recommended by official React Docs: https://reactjs.org/docs/testing.html#tools

This PR:

  • adds React Testing Library packages;
  • removes Enzyme;
  • rewrites existed Enzyme tests to React Testing Library.

@helenjer helenjer requested a review from amje May 9, 2022 02:05
@yc-ui-bot
Copy link
Contributor

Preview is ready.

@helenjer helenjer self-assigned this May 9, 2022
@helenjer helenjer force-pushed the add_testing-library_for_tests branch from 7dda8a3 to b3d877f Compare May 11, 2022 15:26
@amje amje changed the title feat(tests): replace Enzyme with React Testing Library feat(test): replace Enzyme with React Testing Library May 11, 2022
@amje amje merged commit 403b303 into main May 11, 2022
@amje amje deleted the add_testing-library_for_tests branch May 11, 2022 17:46
@yc-ui-bot yc-ui-bot mentioned this pull request May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amje amje amje approved these changes

Assignees

@helenjer helenjer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helenjer @yc-ui-bot @amje