feat: add native copy method #1852
Conversation
ogonkov
requested review from
goshander,
SeqviriouM,
Raubzeug,
amje,
ValeraS and
korvin89
as code owners
|
Preview is ready. |
|
Visual Tests Report is ready. |
ogonkov
force-pushed
the
feat/native_copy
branch
from
0c4054d
to
8afb15d
Compare
| @@ -0,0 +1,7 @@ | |||
| export function copyText(text: string) { | |||
| if (navigator.clipboard.writeText) { | |||
There was a problem hiding this comment.
navigator?.clipboard?.writeText ?
There was a problem hiding this comment.
I think if is better for possible stackatrace investigation
There was a problem hiding this comment.
but it is possible that application will fail, if there's no clipboard in navigator proto. We don't use try ... catch when using copyText.
I suggested not removing if, but add checks like if (navigator?.clipboard?.writeText) { ... }
ogonkov
force-pushed
the
feat/native_copy
branch
from
cc4705e
to
d6bc68b
Compare
| @@ -0,0 +1,7 @@ | |||
| export function copyText(text: string) { | |||
| if (navigator.clipboard.writeText) { | |||
There was a problem hiding this comment.
but it is possible that application will fail, if there's no clipboard in navigator proto. We don't use try ... catch when using copyText.
I suggested not removing if, but add checks like if (navigator?.clipboard?.writeText) { ... }
Fixes #658