feat(Label)!: new xs size and click action for more custom label #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Template for new TagInput component |
|
Preview is ready. |
mfyodorov
reviewed
Nov 24, 2022
src/components/Label/Label.scss
Outdated
Comment on lines
259
to
266
| &:not(#{$disabled}) #{$block}__icon_interactive { | ||
| --yc-button-background-color: transparent; | ||
| --yc-button-background-color-hover: var(--yc-color-text-secondary); | ||
|
|
||
| &:hover { | ||
| color: var(--yc-color-text-inverted-primary); | ||
| } | ||
| } |
There was a problem hiding this comment.
This code copy-pasted from themeState mixin with a tiny change, maybe there is a way to avoid it?
mfyodorov
reviewed
Nov 24, 2022
| @@ -71,7 +71,7 @@ $transitionTimingFunction: ease-in-out; | |||
| } | |||
|
|
|||
| &_size { | |||
| &_s { | |||
| &_xs { | |||
There was a problem hiding this comment.
This is a breaking change, don't forget about it
mfyodorov
approved these changes
Nov 24, 2022
amje
requested changes
Nov 24, 2022
goshander
changed the title
…into feat/label-plain-style
goshander
requested review from
resure,
krozhkov,
DarkGenius and
korvin89
as code owners
|
@goshander Looks like last label (see screenshot) doesn't depend on size: |
amje
changed the title
Thanks, fixed |
amje
approved these changes
Dec 23, 2022
amje
pushed a commit
that referenced
this pull request
Jan 12, 2023
ValeraS
pushed a commit
that referenced
this pull request
Jan 17, 2023
amje
pushed a commit
that referenced
this pull request
Jan 20, 2023
amje
pushed a commit
that referenced
this pull request
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to customize label for create new TagInput component with Label and TextInput collaboration