-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Label)!: new xs size and click action for more custom label #380
Conversation
Preview is ready. |
src/components/Label/Label.scss
Outdated
&:not(#{$disabled}) #{$block}__icon_interactive { | ||
--yc-button-background-color: transparent; | ||
--yc-button-background-color-hover: var(--yc-color-text-secondary); | ||
|
||
&:hover { | ||
color: var(--yc-color-text-inverted-primary); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code copy-pasted from themeState
mixin with a tiny change, maybe there is a way to avoid it?
@@ -71,7 +71,7 @@ $transitionTimingFunction: ease-in-out; | |||
} | |||
|
|||
&_size { | |||
&_s { | |||
&_xs { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change, don't forget about it
…into feat/label-plain-style
@goshander Looks like last label (see screenshot) doesn't depend on size: |
Thanks, fixed |
I want to customize label for create new TagInput component with Label and TextInput collaboration