feat(Toaster): add "has" method

[oynikishin]

No description provided.

[gravity-ui-bot]

Preview is ready.

[korvin89]

I think callback word is redundant

[korvin89]

Why there are no onMount, onUnmount dependencies here?

[oynikishin]

I don't want to do smth when onMount or onUnmount changes.
onMount and onUnmount should fired only once during corresponding stages.
Using React.useEffect without deps is common pattern for this case as I know.
Actual value of these functions will be used when time comes.

[korvin89]

I think it is a little bit unfair. Component does not detect changing of this props. Maybe you should add ref that stores value isMount and use it in effect

[korvin89]

Ok. I'll leave it up to Alexey @ogonkov :)

[ValeraS]

What task do we solve here? We need callbacks for toast addition and deletion events, right? If so, it is better to call them from appropriate methods from ToasterProvider (add, remove, removeAll).

[oynikishin]

The main goal is to provide API that helps developers to understand when they cannot reuse (update) old toast and have to create another one.

I chose to provide unmount event because it is easy to understand API and solves my problem not ideal but well enough.
(mount is added for symmetry).

The problem with remove is that I don't quite understand what it is.
Technically a toast is removed when it is deleted from the list of toasts.
But in fact a toast becomes "invalid" when it enters the ToastStatus.Hiding stage.
We can still change the content but we can no longer affect allowAutoHiding and timeout props.
And maybe it would be better for the developer to recreate the toast and not try to update the current hiding one.

Maybe it will be better to provide a ToastStatus change event with extra status like removed..?
I need your advice!

[ogonkov]

Can you provide example of usage of this api?

[oynikishin]

Can you provide example of usage of this api?

I need smth like this:

    const createUpdatableToast = (name: string, title: string) => {
        let toastExists = false;
        const addToast = (newTitle: string) => {
            toaster.add({
                name,
                title: newTitle,
                onUnmount: () => {
                    toastExists = false;
                }
            });
            toastExists = true;
        };

        const addOrUpdateToast = (newTitle: string) => {
            if (toastExists) {
                toaster.update(name, { title: newTitle});
            } else {
                addToast(newTitle);
            }
        };

        addToast(title);
        return addOrUpdateToast;
    }

There is several ways to solve my problem:

• different variants of close callback (at least three))
• or maybe some method like addOrUpdate (...why not)

As I already mentioned.
I chose mount/unmount event because it is enough for my case and it is well self-documented api.

But may be you suggest the best way!

[ogonkov]

toBe(false)

you interested in returning boolean from api, not some falsy value

[oynikishin]

Fixed!

[ValeraS]

React documentation recommends not writing or reading ref.current during rendering https://beta.reactjs.org/reference/react/useRef#caveats

[oynikishin]

Fixed