feat(Button): add xs Button size #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
Marginy605
force-pushed
the
button-xs-size
branch
from
ac2b5d2
to
c029bbf
Compare
Marginy605
force-pushed
the
button-xs-size
branch
from
c029bbf
to
ed129a6
Compare
Marginy605
commented
May 15, 2023
| @@ -122,7 +122,7 @@ export function withTableActions<I extends TableDataItem, E extends {} = {}>( | |||
| disabled={disabled} | |||
| className={BUTTON_CLASSNAME} | |||
| onClick={this.handleActionsButtonClick.bind(this, {item, index})} | |||
| size={rowActionsSize} | |||
| size={rowActionsSize as ButtonSize} | |||
There was a problem hiding this comment.
Only for Button component
Marginy605
force-pushed
the
button-xs-size
branch
from
ed129a6
to
024051a
Compare
Marginy605
commented
May 15, 2023
| @@ -54,7 +54,7 @@ export type TableActionConfig<I> = TableAction<I> | TableActionGroup<I>; | |||
|
|
|||
| export interface WithTableActionsProps<I> { | |||
| getRowActions: (item: I, index: number) => TableActionConfig<I>[]; | |||
| rowActionsSize?: ButtonSize; | |||
| rowActionsSize?: Exclude<ButtonSize, 'xs'>; | |||
There was a problem hiding this comment.
Prop is used for Button and Menu components at the same time. But Menu doesn't support xs size.
amje
requested changes
May 15, 2023
src/components/Button/Button.scss
Outdated
Comment on lines
110
to
113
| &_side_right { | ||
| margin-right: 6px; | ||
| width: var(--yc-button-icon-size); | ||
| } |
There was a problem hiding this comment.
No need to set these styles, width: var(--yc-button-height); does all the work. Same relates to &_side_left
| /** | ||
| * common sizes for Menu and Button | ||
| */ | ||
| export type RowActionsSize = 's' | 'm' | 'l' | 'xl'; |
There was a problem hiding this comment.
TableRowActionsSize would be better and can be exported safely
korvin89
approved these changes
May 15, 2023
Marginy605
force-pushed
the
button-xs-size
branch
from
e2c6825
to
5568359
Compare
amje
approved these changes
May 15, 2023
krozhkov
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.