feat(Label): added value prop for "key:value" labels #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
sunduckcow
changed the title
amje
requested changes
Jun 1, 2023
amje
requested changes
Jun 1, 2023
sunduckcow
force-pushed
the
labels-support-key-value
branch
from
1d0671b
to
1abe528
Compare
added 12 commits
June 7, 2023 15:50
That also fixes bad display of left addon (icon) in 's' size
It allows you to use labels as pairs "key : value"
sunduckcow
force-pushed
the
labels-support-key-value
branch
from
76a869d
to
272e29e
Compare
amje
requested changes
Jun 7, 2023
amje
approved these changes
Jun 8, 2023
goshander
approved these changes
Jun 9, 2023
sunduckcow
force-pushed
the
labels-support-key-value
branch
from
56df37d
to
2101dab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this pr
fixed: bad display of icon in 's' size labels
refactored: styles for different sizes
added: support for value prop + story for display all combinations of labels