Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Link): add visitable prop #872

Merged
merged 6 commits into from
Aug 14, 2023
Merged

feat(Link): add visitable prop #872

merged 6 commits into from
Aug 14, 2023

Conversation

helenjer
Copy link
Contributor

@helenjer helenjer commented Aug 8, 2023

Adds views for visited primary and secondary links
[UXRFC-163]

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@helenjer helenjer changed the title feat(Link): add primary-visitable nad secondary-visitable view feat(Link): add primary-visitable and secondary-visitable view Aug 8, 2023
@amje
Copy link
Contributor

amje commented Aug 8, 2023

@helenjer What about instead of adding new views we add a new prop visitable?

@helenjer
Copy link
Contributor Author

helenjer commented Aug 8, 2023

@amje I thought to do it in a next major
In other case we will get a breaking change for normal-visitable (need to be removed) or inconsistent API (normal-visitable and secondary + visitable, primary + visitable)

@helenjer
Copy link
Contributor Author

@amje changed to new visitable prop

@helenjer helenjer changed the title feat(Link): add primary-visitable and secondary-visitable view feat(Link): add visitable prop Aug 14, 2023
@helenjer helenjer merged commit 62903e5 into main Aug 14, 2023
3 checks passed
@helenjer helenjer deleted the add_visitable_links_views branch August 14, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants