build: modular assembly #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itwillwork
commented
Jun 14, 2024
| "from": "./src/autocomplete/databases/!(yql)/**/*" | ||
| }, | ||
| ] | ||
| }] |
There was a problem hiding this comment.
eslint rule for blocking cross imports
itwillwork
commented
Jun 14, 2024
| "./mysql": "./dist/databases/mysql/index.js", | ||
| "./postgresql": "./dist/databases/postgresql/index.js", | ||
| "./yql": "./dist/databases/yql/index.js" | ||
| }, |
roberthovsepyan
requested changes
Jul 3, 2024
itwillwork
force-pushed
the
database-separate-build-p2
branch
from
146ff97
to
834809d
Compare
build.js
Outdated
| outfile: 'dist/index.js', | ||
| tsconfig: './tsconfig.build.json', | ||
| }); | ||
| // eslint-disable-next-line @typescript-eslint/explicit-function-return-type |
There was a problem hiding this comment.
Are you sure there's no way to do write it differently? If not, at least write a comment explaining why you need to disable it.
There was a problem hiding this comment.
the script has been rewritten, there is no more comment
roberthovsepyan
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see gravity-ui/rfc#14