Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially support GRANT command #226

Merged
merged 10 commits into from
Oct 10, 2024
Merged

Partially support GRANT command #226

merged 10 commits into from
Oct 10, 2024

Conversation

viladimiru
Copy link
Contributor

@viladimiru viladimiru commented Oct 9, 2024

No description provided.

Comment on lines 23 to +25
: notInsertStatement (INTO OUTFILE STRING_LITERAL)? (FORMAT identifierOrNull)? (SEMICOLON)?
| insertStatement
| grantStatement
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to refactor noInsertStatement in the future, current implementation is wrong
https://st.yandex-team.ru/WEBSQL-203

Copy link
Collaborator

@NikitaShkaruba NikitaShkaruba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🥇 Let's polish it a bit more

tsconfig.json Show resolved Hide resolved
.eslintrc Show resolved Hide resolved
@viladimiru viladimiru merged commit ef66174 into main Oct 10, 2024
4 checks passed
@viladimiru viladimiru deleted the support-grant-command branch October 10, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants