feat: Handle errors for INSERT template
#62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viladimiru
commented
Aug 7, 2023
| } | ||
| ; | ||
|
|
||
| OptionalParenthesizedColumnListOrError |
There was a problem hiding this comment.
NikitaShkaruba
approved these changes
Aug 7, 2023
| } | ||
| ] | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
We also need a test case for the next query INSERT INTO table() VALUES(|) (| is a cursor), right?
There was a problem hiding this comment.
I'm not pretty sure, because if our cursor inside of the VALUES brackets anyway we will have empty context, with errors and without them, because we don't suggest here anything
There was a problem hiding this comment.
My bad, you are correct.
This was referenced Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28