-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add special rendering for shop=interior_decoration #1406
Comments
Very nice! |
What is the distinction to interior_decoration? Should both get the same icon? |
Probably the same, OSM Wiki does not have definition for interior decoration shops (about 2,5 thousand uses) and looking at Wikipedia it's probably wider category than just furnitures, but don't know how to express it visually and the furniture can be a good symbol for all of it IMO. |
My guess is that interior_decoration may include also things like paints, tiles, paintings, deer head busts, lamps, stained glass etc.
Probably yes. |
the word sounds more like living accessories than furniture |
I wouldn't render them as the same symbol. |
Do you have any idea what symbol could it be? Curtains with lamp? Frame and something? I guess one item would be not general enough for such a broad category as interior decorations. |
I can't think of one, so I'd just leave it as the default symbol. |
2015-04-23 1:51 GMT+02:00 Paul Norman [email protected]:
+1, maybe a flower vase and another living item (curtains?) |
I want to avoid a vase, since I'd like to use that for archaelogical sites. Since interior decoration is not too popular I will not concentrate on a distinct symbol for that right now. |
2015-04-23 16:27 GMT+02:00 nebulon42 [email protected]:
I'd use an amphora there (different shape) |
I guess curtains would be the best for shop=interior_decoration. |
What about something like this: |
Sorry, but this one is not obvious. |
@kocio-pl Can you mention or somehow mark in the issue description that shop=furniture now has its own icon? |
Sure, done. |
I think interior decoration is definitely different from furniture. Decoration shops sell smaller items which have a primarily decorative purpose. Like vases, candles, small lamps, table cloths, etc. They shouldn't have the same icon, imho. Maybe a lustre / chandelier would work...? |
I have tried the chandelier but got no reaction. For me it was great as a proof of concept, but this particular shape turned out to be my failure as a designer - could you draw a better one? We're getting to 6k uses, so it's worth trying. |
I'm currently not planning to add more shop icons and we have them for most of our 10k+ shops (this one is still below that line), so it can be reopened if someone is able to propose a design that is acceptable. |
Now on 9.7k uses. Finding an icon that would work is difficult because these shops sell such a wide range of different things. The English wiki doesn't have a proper definition although the German wiki lists "accessories, tableware, porcelain, small items of furniture, designer pieces, different styles and more." I tend to tag shops that sell (primarily) decorative items for within a home as Maybe a lamp, cushion, ornament or candle icon would work? Any ideas @Tomasz-W? |
I'll try with lamp + picture/ flower. |
Lamp foot should be bigger and maybe you could add a thin pulling switch, but it's already very nice - I'm surprised, especially after my countless tries... |
I like the general idea. I think the flower could be a bit bigger and the pot should be a little smaller. Other than that: Great! |
@kocio-pl I agree about the lamp foot. But I'm not sure a pulling switch would be recognizable. |
Looks good! Only change I'd make is to thicken/widen the lamp base. |
We should start rendering shop=furniture and shop=interior_decoration, probably with this icon from osmfr-cartocss fork:
https://github.com/cquest/osmfr-cartocss/blob/master/symbols/furniture.svg
[It was proposed in meta-issue #1402]
The text was updated successfully, but these errors were encountered: