Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for healthcare=* tags #1981

Closed
morray opened this issue Nov 20, 2015 · 11 comments
Closed

Add rendering for healthcare=* tags #1981

morray opened this issue Nov 20, 2015 · 11 comments

Comments

@morray
Copy link

morray commented Nov 20, 2015

Although the healthcare= tags is still only at about 10% usage of amenity=doctors, it is wothwhile to include it. One advantage is that via the healthcare:speciality=* and healthcare:speciality:*=yes tags can add further information missing in the amenity tagging.

@matkoniecz
Copy link
Contributor

Please, be more precise - which tags you propose to display?

See also https://github.com/gravitystorm/openstreetmap-carto/blob/master/CARTOGRAPHY.md#the-mapper-feedback-loop

@matkoniecz matkoniecz added this to the 3.x - Needs upgrade to openstreetmap-carto.style milestone Nov 20, 2015
@morray
Copy link
Author

morray commented Nov 20, 2015

Hi matkoniecz,

as a start I think
tags | occurrences
healthcare=doctor | 4158
healthcare=dentist | 849
healthcare=centre | 654
healthcare=clinic | 459
should be rendered using the same icons as the corresponding amenity tags

additionally
healthcare=physiotherapist | 1057
healthcare=alternative | 664
might be interesting because of their frequency for dedicated symbols.

Concerning the specialities:
healthcare:speciality=general
healthcare:speciality:general =yes

healthcare:speciality=ophthalmology
healthcare:speciality:ophthalmology = yes

healthcare:speciality=gynaecology
healthcare:speciality:gynaecology = yes

healthcare:speciality=internal
healthcare:speciality:internal = yes

healthcare:speciality = orthopaedics
healthcare:speciality:orthopaedics =yes

healthcare:speciality = otolaryngology
healthcare:speciality:otolaryngology = yes

healthcare:speciality = paediatrics
healthcare:speciality:paediatrics = yes

should add a detail to the doctor symbol.

@matkoniecz
Copy link
Contributor

And which ones would not be covered by already rendered amenity=doctors, amenity=dentist etc?

@matkoniecz
Copy link
Contributor

should add a detail to the doctor symbol.

I consider it highly dubious that it is possible to find icon that would have a clear meaning, would not result in confusion and be readable (14x14 px, single color).

@morray
Copy link
Author

morray commented Nov 20, 2015

Of course these are covered by amenity=doctor and dentist now. But especially for the doctor healthcare is much cleaner, since it puts the type of doctor in the speciality tag. And the detail could be as big as the icon as now done for the dentist.

@matkoniecz
Copy link
Contributor

Of course these are covered by amenity=doctor and dentist now.

In that situation I see no reason for rendering healthcare=* tags. At this moment any properly tagged place will contain amenity=doctors/dentist and maybe some healthcare=* tags.

Maybe in future healthcare=* will be used more widely and in the far future it will replace amenity=doctor/dentist but I see no reason for changes now.

@polarbearing
Copy link
Contributor

I didn't comprehend yet what @morray was proposing. If you say a healthcare=doctor should be rendered even in absence of an amenity tag (@matkoniecz calling the future case), than it would need to be evaluated how much it is needed, since this would encourage to move away from the amenity tagging.
If you propose to render different icons for different doctor's specialities, than I'd say that is too much for the general map, and a case of a healthcare-specific overlay.

@morray
Copy link
Author

morray commented Nov 21, 2015

@polarbearing: exactly that. The tag should be rendered even in absence of the amenity tag. And yes that probably will lead to the healthcare tag being used more frequently. And yes it probably also leads to a switch on the long term ( if presets are adapted as well) since healthcare is much more intuitive than amenity.

@polarbearing
Copy link
Contributor

Understood. Anyway since @matkoniecz already added the 3.x label, this depends on the database upgrade, since the healthcare=* key is currently not imported.

@mboeringa
Copy link

@morray,

I think there first needs to be some of agreement, and possibly emergency Wiki clean up, to deal with the fact that there are now two healthcare related proposals:

Key:healthcare
http://wiki.openstreetmap.org/wiki/Key:healthcare

and

Proposed features/Healthcare 2.0
http://wiki.openstreetmap.org/wiki/Proposed_features/Healthcare_2.0

Actually, the Healthcare 2.0 proposal, which seems more in line with the HOT tagging, does away with most of the direct use of healthcare=x in the original proposal, favouring health_x:type=x, which is a fundamental different tagging scheme.

Actually, there are now at least 4 different ways to tag a hospital, all of which seem to have had some followers and use ;-(:

building=hospital
amenity=hospital (& building=yes/no/NULL/hospital)
healthcare=hospital (& building=yes/no/NULL/hospital)
health_facility:type=hospital (& building=yes/no/NULL/hospital)

@matkoniecz
Copy link
Contributor

Closing for reason explained in #1981 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants