Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linear landforms to natural area exclusion list #2258

Closed
pnorman opened this issue Aug 1, 2016 · 8 comments
Closed

Add linear landforms to natural area exclusion list #2258

pnorman opened this issue Aug 1, 2016 · 8 comments
Labels

Comments

@pnorman
Copy link
Collaborator

pnorman commented Aug 1, 2016

natural=cliff is covered, but others aren't

  • natural=ridge
  • natural=arete

cc @imagico

@pnorman pnorman added the lua label Aug 1, 2016
@imagico
Copy link
Collaborator

imagico commented Aug 1, 2016

Agreed.

Circular ridges are much less common than circular cliffs, the only case where such are commonly found is craters, circular cliffs OTOH also occur with buttes and similar relief forms.

@pnorman
Copy link
Collaborator Author

pnorman commented Aug 1, 2016

Do any other natural=* tags that are for linear features come to mind?

@HolgerJeromin
Copy link
Contributor

According to wiki:

  • tree_row
  • valley
  • river_terrace
  • coastline (has special handling anyway)

@imagico
Copy link
Collaborator

imagico commented Aug 1, 2016

tree_row is already included, valley and river_terrace have no meaning as a closed way other than an area so the answer is none.

There is natural=hedge with ~500 uses but that's just wrong tagging for barrier=hedge probably.

@matthijsmelissen
Copy link
Collaborator

@kocio-pl Do you have time to write a PR for this?

@kocio-pl
Copy link
Collaborator

I have the time, but I'm totally lost here.

I don't understand what "natural area exclusion list" is and how could we exclude the things which are not rendered yet. I thought it's what @Ircama was trying to achieve. After him closing #2138 I'm not even sure what to do.

Could you elaborate how this code should work?

@pnorman
Copy link
Collaborator Author

pnorman commented Nov 14, 2016

https://github.com/gravitystorm/openstreetmap-carto/blob/lua/openstreetmap-carto.lua#L40 needs changing

@matthijsmelissen
Copy link
Collaborator

Resolved by #2455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants