Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision between entrance boxes and address labels or icons #3038

Open
polarbearing opened this issue Jan 26, 2018 · 13 comments
Open

Collision between entrance boxes and address labels or icons #3038

polarbearing opened this issue Jan 26, 2018 · 13 comments

Comments

@polarbearing
Copy link
Contributor

With the rendering of entrances as small boxes in #2936, there is a collision when labes or icons are rendered from the same node.

It is quite frequent that addr:housenumber is on the entrance node,
http://www.openstreetmap.org/node/2825036652 18000 times in Berlin,
or a shop icon in addition,
http://www.openstreetmap.org/node/2446830336 99 times in Berlin

Depending on the shape of the label or the icon, elements of the entrance box remain visible, creating a systematic pixel clutter that is not originated by the building geometry.

Examples:
Housenumber 7 looks like in a circle:
7
71 looks like 7.1:
71
The jewellery ring has the entrance in the middle:
ring

I could imagine the following methods to avaid this:

  • putting the address labels on a shield that is larger than the entrance box
  • making the inside of icons in-transparent
  • not rendering the box when a label or icon is present
@kocio-pl
Copy link
Collaborator

kocio-pl commented Feb 1, 2018

@tpikonen What do you think about these problems? Do you think you could fix them?

@tpikonen
Copy link
Contributor

Personally I don't think this problem is as bad as the examples make it seem, but if this needs to be fixed, I think the easy options are

  1. Further increase the halo of address labels on high zooms where entrances are rendered.
  2. Move the entrance marker layer on top and do not allow overlap, i.e. do not render the marker when there is something else nearby.

Option one would fix the first two examples (probably) but leave other markers overlapping. I don't see why amenities should be tagged on the entrances though.

Option two would be a more invasive fix, but would fix all these cases.

@geozeisig
Copy link

The problem with the shop on the entrance can also be interpreted as bad tagging. If the shop is tagged on a separate node in the building, both can be rendered better. (I know there are long discussions on this topic and I do not want to restart them here.) It will be difficult for the renderer itself to put the shop in the building.

@dieterdreist
Copy link

dieterdreist commented Feb 15, 2018 via email

@Tomasz-W
Copy link

Tomasz-W commented Feb 15, 2018

Is it possible to render entrance in the node place and (at the same time) housenumber under/ on the right side of it's icon with some distance between them?

@tuukka
Copy link

tuukka commented Mar 8, 2018

To expand the proposal by @Tomasz-W,, please render any housenumber (e.g. 7) and/or entrance ref (e.g. B) next to (or inside) the entrance icon.

@matkoniecz
Copy link
Contributor

I consider

+1, I agree that it is topologically bad mapping, because the shop is in
the building (only inside), while the entrance is on the perimeter of the
building, i.e. the limit between inside and outside (it is both, inside and
outside). Aside from rendering aspects it is "halfway wrong".

argument as convincing. Why mapping jeweler location within door would be correct?

@HolgerJeromin
Copy link
Contributor

Why mapping jeweler location within door would be correct?

The mapping of the entrance to the shop is clear with this tagging. No need to find the nearest entrance for this shop. But this is no strong argument

@dieterdreist
Copy link

dieterdreist commented Oct 2, 2019 via email

@HolgerJeromin
Copy link
Contributor

My usecase would be something like the following building with two POI and three entrances. Which entrance should a router use to bring you to the hairdresser? (The middle entrance is to the apartments in the top floors.)

image

But again, I do not say mapping the poi on the entrance is correct, just playing devil's advocate.

@dieterdreist
Copy link

dieterdreist commented Oct 4, 2019 via email

@jeisenbe
Copy link
Collaborator

While the issue with POI icons might be wrong mapping, it's certainly encouraged to add addr:housenumber and addr:unit tags to building entrances, especially in certain countries where the address is directly associated with the door.

One possibility would be to use text-dy to move the addr text down below the icon.

@Dimitar5555
Copy link

Dimitar5555 commented Jan 30, 2024

One possibility would be to use text-dy to move the addr text down below the icon.

OsmAnd does it and it seems to work well.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests