Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A main entrance does not stand out well if the building is major #3071

Open
geozeisig opened this issue Feb 14, 2018 · 12 comments
Open

A main entrance does not stand out well if the building is major #3071

geozeisig opened this issue Feb 14, 2018 · 12 comments

Comments

@geozeisig
Copy link

A main entrance does not stand out well if the building is a church, train station or airport passenger building. Example: Berliner Dom, S-Bahrenfeld
Maybe we should make the entrance in this case even darker.

@kocio-pl
Copy link
Collaborator

@tpikonen What's your take on this? I'm also unsure about #3038.

@dieterdreist
Copy link

dieterdreist commented Feb 14, 2018 via email

@tpikonen
Copy link
Contributor

I agree that these examples look pretty bad. Also, buildings-major and places of worship are also the places where map users probably benefit the most from seeing main entrances.

Technically this can be fixed in the SQL level by getting suitable building/way tags from a spatial intersection of the entrance with the building (similar to the solution proposed in PR #2932) and adjusting the color.

The more straightforward solution would be to make all main entrances dark enough to be visible also in these dark buildings.

@dieterdreist
Copy link

dieterdreist commented Feb 14, 2018 via email

@polarbearing
Copy link
Contributor

Could we change the title of this issue, s/public/major/ ?

@kocio-pl kocio-pl changed the title A main entrance does not stand out well if the building is a public building. A main entrance does not stand out well if the building is major Feb 15, 2018
@Tomasz-W
Copy link

I've missed a discussion about entrances rendering, and now I find these boxes not intuitive at all. Wouldn't be the classic door symbol from architectural plans suit better here?

https://www.google.pl/search?client=opera&hs=rev&biw=1920&bih=981&tbm=isch&sa=1&ei=mDCFWounD4aVsAGZvIPICQ&q=door+archi+symbol&oq=door+archi+symbol&gs_l=psy-ab.3...20463.21680.0.21985.5.5.0.0.0.0.0.0..0.0....0...1c.1.64.psy-ab..5.0.0....0.JJp_pckK8TA#imgrc=Fwwb35op2dNOKM:

@dieterdreist
Copy link

dieterdreist commented Feb 16, 2018 via email

@tpikonen
Copy link
Contributor

I've missed a discussion about entrances rendering, and now I find these boxes not intuitive at all. Wouldn't be the classic door symbol from architectural plans suit better here?

I also thought about this, but this symbol would only work when rotated correctly and getting the direction of the building way requires a rather complicated SQL query. dieterdreist's arguments above against it are also compelling.

I would like to fix this bug and it looks like it requires changes at the SQL level anyway, so maybe the rotated entrance markers will happen. I'm afraid I don't have the time to work on this soon though.

@jeisenbe
Copy link
Collaborator

Was this issue fixed by #3659 (Lighten major buildings fill and outline) or is it still a problem?

@pnorman
Copy link
Collaborator

pnorman commented Jul 10, 2022

There's almost zero contrast between the entrance square and the major building fill.

image

For comparison,
image

The Dom example may have tagging issues, but it does show the lack of contrast very well
image

There's two options. One is to change the colour of entrances globally, and the other is to change it for only major buildings. The former is easy, the latter would require querying for buildings the entrance touches. This is practical - the entrances SQL is simple, and we do similar things with turning circles.

@imagico
Copy link
Collaborator

imagico commented Jul 10, 2022

The other obvious design option would be to change the entrance symbol otherwise to work better on different backgrounds, like for example adding a halo. Intuitively i'd say neither this or a stronger color would work well - but i can't say for sure without testing.

Keep in mind that the whole concept of so called major buildings is still an open issue (#2532) - it could be advisable to think these two together.

@dieterdreist
Copy link

current symbol works for me, the access ways are very clear to understand what this is, I’d keep the entrances without white fill, halo or similar, in a deemphasized styling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants