-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A main entrance does not stand out well if the building is major #3071
Comments
2018-02-14 14:46 GMT+01:00 geozeisig <[email protected]>:
A main entrance does not stand out well if the building is a church, train
station or airport passenger building. Example: Berliner Dom
<https://www.openstreetmap.org/node/1967329593>, S-Bahrenfeld
<https://www.openstreetmap.org/node/3527774968>
Maybe we should make the entrance *in this* case even darker.
the Berliner Dom case is not mapped well, because the entrance isn't part
of the building but only of a building part which is inside the building.
|
I agree that these examples look pretty bad. Also, buildings-major and places of worship are also the places where map users probably benefit the most from seeing main entrances. Technically this can be fixed in the SQL level by getting suitable building/way tags from a spatial intersection of the entrance with the building (similar to the solution proposed in PR #2932) and adjusting the color. The more straightforward solution would be to make all main entrances dark enough to be visible also in these dark buildings. |
2018-02-14 16:42 GMT+01:00 tpikonen <[email protected]>:
The more straightforward solution would be to make all main entrances dark
enough to be visible also in these dark buildings.
or the opposite: very bright
|
Could we change the title of this issue, s/public/major/ ? |
I've missed a discussion about entrances rendering, and now I find these boxes not intuitive at all. Wouldn't be the classic door symbol from architectural plans suit better here? |
sent from a phone
On 15. Feb 2018, at 12:46, Tomasz Wójcik ***@***.***> wrote:
Wouldn't be the classic door symbol from architectural plans suit better here?
it is not usable for the scales with which we typically deal in OSM and it implies a lot of details (number of parts, direction, opening side and size) which we don’t tag. For entrances the classical symbol is an arrow.
|
I also thought about this, but this symbol would only work when rotated correctly and getting the direction of the building way requires a rather complicated SQL query. dieterdreist's arguments above against it are also compelling. I would like to fix this bug and it looks like it requires changes at the SQL level anyway, so maybe the rotated entrance markers will happen. I'm afraid I don't have the time to work on this soon though. |
Was this issue fixed by #3659 (Lighten major buildings fill and outline) or is it still a problem? |
The other obvious design option would be to change the entrance symbol otherwise to work better on different backgrounds, like for example adding a halo. Intuitively i'd say neither this or a stronger color would work well - but i can't say for sure without testing. Keep in mind that the whole concept of so called major buildings is still an open issue (#2532) - it could be advisable to think these two together. |
current symbol works for me, the access ways are very clear to understand what this is, I’d keep the entrances without white fill, halo or similar, in a deemphasized styling |
A main entrance does not stand out well if the building is a church, train station or airport passenger building. Example: Berliner Dom, S-Bahrenfeld
Maybe we should make the entrance in this case even darker.
The text was updated successfully, but these errors were encountered: