-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private parking icon should have priority lower than normal parking icon #312
Comments
+1, also Text and other icons are mostly more important than private parking icons |
Important to point out: |
yea, lvl 15 seems too far out for private parking. You assume the supermarket has parking available, but you might need to know where the public parknride is around a freeway interchange. you probably need to find private parking in relation to the building(s), not the town - so lvl 15 is too far out. 16 would be better zoom level to start seeing Private parking show up (when the P would fit inside a parking lot) |
+1 Beyond this, I think a different symbol is appropriate. Destination parking is only relevant to a person with a specific destination, to everyone else it is just a land use. Public parking however is someone one might seek. |
related issue: #287 (comment) (private parking icon is probably blocking display of university name) |
@gravitystorm @pnorman - thoughts? |
I can't imagine they will want behaviour like this. There is different behaviour in Carto to what it used to be like as there we had different shading of the P for normal, customer and private. Now (I presume since this carto style came out or it was changed ages ago) we just render normal (full colour P) and not normal (ligher P). Technically it render the full colour P if access tag does not exist or access tag does not equal public or access tag does not equal 'yes' otherwise it will display the ligher P. "CloCkWeRX commented 3 days ago Important to point out: I don't have a working machine with the database to test this fix I wrote but to have the same behaviour and just render non private at zoom 15 and both at zoom 16 amenity-points.mss replacing lines 166-172 |
gravitystorm#312 I am pretty sure that is right but cannot test atm.
Thanks for the code Rovastar. I can always make a different icon for P if you want (at least I can try). Is making icons part of -carto, or is that some whole separate thing? the current private P looks good for the customers - would an even more transparent P work for access != private;no ? |
""CloCkWeRX commented 3 days ago Important to point out: In this case only one is rendered, as two symbols are too close to render both - see links in original report. |
While I think mappers should continue to tag private parking for stores and such, |
I second pushing private parking to z17 or 18, but it depends a little on what people tag. Parking in front of a mall could be only for customers, mainly for customers or for everyone in the area. |
Mall parking should be tagged customers. The employee parking in the back with the service docks would be private, and having it render at a higher zoom level than customers would be correct.
|
From a cartography point of view, the map should show the explicitly public parking first. That's clearly a place to direct people to: they can learn which malls don't enforce parking rules later :-). |
I think that after other changes related to parking icons it is no longer a problem. Solving it would just add more complexity to style that is not currently necessary. |
+1 |
BTW: as already mentioned in a different issue, I guess maybe for showing not-public parking icon we should rather use the code like: [access != null][access != 'yes'] {
marker-opacity: 0.33;
} because "access=public" is defined just for toilets and it's not sure if we should use [access != ''] syntax? [EDIT:] I guess this is new issue now for resolving this problem. |
http://www.openstreetmap.org/?mlat=50.0462&mlon=19.8828#map=15/50.0462/19.8828 displays private parking icon
blocking nearby parking icon - see http://www.openstreetmap.org/?mlat=50.0460&mlon=19.8824#map=16/50.0460/19.8824
IMHO private parking should not block rendering of normal parking icon as it is way less useful and important information
related to #70
The text was updated successfully, but these errors were encountered: