Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move amenity=post_box to z19+ #3431

Closed
Adamant36 opened this issue Oct 6, 2018 · 26 comments
Closed

Move amenity=post_box to z19+ #3431

Adamant36 opened this issue Oct 6, 2018 · 26 comments

Comments

@Adamant36
Copy link
Contributor

Now that ATMs are rendered at z19+ I think post boxes should also be. As they suffer from a lot of the same issues at higher zoom levels as ATMs did. I noticed @kocio-pl mentioned them in issue #1745 and the reasons are still valid.

My own reasons for wanting it at z19+ is that they clutter things up to much otherwise. Plus, the icon blocks more important icons and names at higher zoom levels. Also, its a small feature that is not used that often, and is only important on a neighborhood or even block level. Therefore, rendering it at z19+ just makes sense. Especially in more dense metro areas, where a lot of them are mapped.

https://www.openstreetmap.org/#map=17/38.77231/-121.36215 (clutter)
2018-10-06 2
https://www.openstreetmap.org/#map=17/37.78930/-122.40474 (blocking more important things)
2018-10-06 2

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 6, 2018

Thanks for finding a clutter example - it should never look this way, it's just horrible!...

Here's also more visible illustration of the San Francisco problem (which will be not too obvious until we deploy #3410):

screenshot_2018-10-06 overpass turbo

@boothym
Copy link
Contributor

boothym commented Oct 8, 2018

Are those actually post boxes in the first example - as in, somewhere you put mail that you want to send? I'm not American but they almost look like something you'd see for receiving mail: https://binged.it/2yiISg6 - especially this one with house numbers on it: https://binged.it/2yq38MG

Plus, I would not want post boxes moved to z19, just because you've found somewhere that has an extreme density of post boxes (that's if they're even properly tagged) compared to the rest of the world.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 8, 2018

Thanks, that's good point - they should be probably tagged like this:

https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dletter_box

Still the problem are post boxes in the city, especially eclipsing roads, which will be visible after #3410. Look at the Post Street (!) example...

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 8, 2018

Letter boxes were tagged like 5 years ago, when there was no other tag probably:

https://www.openstreetmap.org/node/1559988088

the raise of a proper tag is quite fresh:

taghistory 61

@dieterdreist
Copy link

dieterdreist commented Oct 8, 2018 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 8, 2018

I'm not sure - what about objects like amenity=waste_disposal + access=private? But this is off topic here, it's strictly tagging problem.

@dieterdreist
Copy link

dieterdreist commented Oct 8, 2018 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 8, 2018

Then we have like 5 mln problems, mostly showing private roads (3.8 mln)...

https://taginfo.openstreetmap.org/tags/access=private#combinations

taghistory 62

@dieterdreist
Copy link

dieterdreist commented Oct 8, 2018 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 8, 2018

Who do you think cares for roads with the private access? It's not even for delivery (other access value).

@dieterdreist
Copy link

dieterdreist commented Oct 8, 2018 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 8, 2018

So are letter boxes - they are private, but post delivery uses them to fill them up with mails.

@dieterdreist
Copy link

The whole paragraph was about amenity, so roads do not matter.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 8, 2018

Why not? The discussion about access=private might exclude every object from tagging. But amenity=waste_disposal is the same - it might be private, but in every case I know it's operated by some external cleaning service, just like letter boxes.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 8, 2018 via email

@Adamant36
Copy link
Contributor Author

@dieterdreist, there was discussion in a note about if the mail boxes were tagged probably or not. It didn't go anywhere though because its hard to tell as an arm chair mapper that doesn't live in that area, and there are to many to re-tag anyway. Plus, what other tag is there? There was also speculation that the mailboxes might have been originally by someone representing the local post office and that they are using them on a map for mail delivery and pickup. There is really no way to know. But its an assumption to say it was just micro mapped by an arm chair mapper that was just mapping whatever they felt like.

Also, its an assumption to say they aren't important to anyone, the post office aside, because its something usable by the 30 or 40 houses in that area. Otherwise, your stuck debating scale of usefulness, which won't go anywhere. Or the same could same be said for neighborhood parks. "I don't live there or go that park. So why should it matter?" To me, that's not an answerable question and it shouldn't matter to what gets render or how.

As far as the access debate goes. I think its worth debating because what is access anyway? People should map physical things and not worry about who can or can't use them. Since like my example above, everything geographical is important to someone and who knows if those people are using the map to see that item or not. It might help people visiting someone that has a really long drive to have us map it for their router, even if it is private, or what about private roads with a bunch of houses on them where the roads being mapped might be useful to emergency crews, despite their private access?

I've gotten in a lot of debates with other mappers who deleted roads outside their houses because they didn't like people driving down them. Even though the roads are public or considered only for emergency situations. It gets to be a slippery slope of who can access the thing, why, and if it warrants mapping or not based on those variables. The same goes for private swimming pools. I was just reading about how fire crews in the L.A. area used pools mapped on OSM to help them fight the fires down there. So, I say its better not to get in a debate about it in the first place, since we can't know all the possible variables, and just map/render what's geographically there.

@dieterdreist
Copy link

dieterdreist commented Oct 9, 2018 via email

@Adamant36
Copy link
Contributor Author

@dieterdreist, I appreciate the clarification. You might have a point. I'd have to think about it more. I'm not asking for anything related to letter boxes though and I'm pretty sure the mail boxes in my example are not letter boxes. I think there might be a definition difference between America and Europe in what counts as a post box, which could be part of the problem.

We don't use the term letter box here. We call them mail boxes, where as the term post box is reserved for things at the post office. There are also mail boxes on residential street corners with multiple in boxes and an out going slot that serve everyone on the block. I don't consider them in the same league as the blue public mail boxes and they don't count as a letter box. Since multiple people on the block use them. They are semi private though. Random people can't drop mail in them and you need a key to get mail out. So maybe they would be considered private access or letterboxes, depending on your definition of those terms. Who knows though. That's why I think its better not to go down that road in the first place and to just assume they are mapped correctly. Although, you could be right and they very well might not be.

I also agree with you that the density is probably an anomaly, but I like to think ahead a little and there is a lot of opportunity for way more dense mapping of post boxes in the future. So I figure its better to preempt it. Plus, there's also the other issues and the icon just inconsistent and doesn't fit in at z17. I feel like that's the "civic/activity" zoom level and z19 is the amenity (bench, bbq, post box, phone, etc) level. I think the fact that rendering is inconstant on Z17 is a real issue to. People should see on the map whats mapped. It should not be completely random what shows up at a zoom level. Sending some "less important" items down a few zoom levels is the only solution.

I wish Z18 was utilized more to, but that's another issue.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 10, 2018 via email

@Adamant36
Copy link
Contributor Author

I would be fine with Z18. As it mostly solves the issue. It would probably work for ATMs also. It seems like z18 isn't really being used as a unique rendering level much though for some reason.

@kocio-pl, is there a specific reason you went with z17 over z18 with the ATM thing and is there a good design reason or something why z18 doesn't get used that often in general for a rendering starting point?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 10, 2018

I'm cautious with that. As you both know, I search for universal rule and it currently seems to me that size rule is the most universal one, so I try to stick with that to have some solid foundation we could build on.

I'm reluctant because of that:

  • the size of the post box is small, so it belongs to z19+
  • on z18 shop icons appear (and soon I expect we do the same for another important POI category - gastronomy), so it can eclipse them
  • on z18 partial road eclipse happens (although not as bad as on z17)

@dieterdreist
Copy link

dieterdreist commented Oct 10, 2018 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 10, 2018

and fire alarm buttons on z22 because they are tiny ;)

If we ever really start using z20+ it sounds pretty OK. It would be probably red, so it'd be enough to show what kind of object it is among similar sized objects.

Reality check: if we would go by the size rule, we would have to give parkings precedence over the shops they are encircling (in certain context). Desirable?

I use relative size rule for a castle/defensive tower for example as a substitute of a real "show all belonging objects later than main one" rule (see #2896). In the meantime we have parkings showing their symbol and label according to their size alone, because I don't know how to detect when they belong to some other entity,

@Adamant36
Copy link
Contributor Author

@dieterdreist, there is no fire alarm button tag and even if there was, it doesn't mean this would be the place to render it anyway. So...You might have a point with letterboxes maybe, but 1. They aren't even rendered in the first place 2. There's no reason they couldn't be on z19 with ATMs etc if they were.

I've been thinking about the size thing the last few days, maybe it would be a valid point that things like ATMs and post boxes shouldn't be rendered on z19, because then your left with no closer zoom level to render smaller things, except, there isn't anything smaller then them with tags at this point and who know if there ever will be. Except your one example of letter boxes. So unless your saying that the map shouldn't utilize a whole zoom level or that @kocio-pl's idea is bad from one example that isn't even rendered, I don't know what the issue is. Its not like rendering levels or @kocio-pl's idea can't be modified again in a couple of years when there's enough "tiny item tags" if need be. Plus, it probably wont be an issue once vector maps come along anyway. So, there's no reason to keep rendering things in a bad way until then, "just because."

@dieterdreist
Copy link

dieterdreist commented Oct 11, 2018 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 11, 2018

It is by the way also inconsistent in itself, as it refers to the 2D projection of things and ignores height / volume.

It's a 2D map, so it makes a lot of sense as a basic metric and is easy to calculate for area rendering. Yet we use also height for towers, because it's also quite easy to use and for towers/masts it's their defining feature.

What I tried to say is that the size rule does not work as an absolute measure with respect to what should be shown and when, nonetheless for every discussion it now appears as first argument.

This rule is used as an absolute measure the whole design is founded on, but modified with some other factors. Even the biggest city is never shown before a country, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants