Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is node golf=hole being rendered the same as golf=pin? #4804

Closed
DaveF63 opened this issue Apr 8, 2023 · 1 comment · Fixed by #4857
Closed

Why is node golf=hole being rendered the same as golf=pin? #4804

DaveF63 opened this issue Apr 8, 2023 · 1 comment · Fixed by #4857
Labels
good first issue remove rendering

Comments

@DaveF63
Copy link

DaveF63 commented Apr 8, 2023

Hi
Why is node golf=hole being rendered the same as golf=pin?

https://www.openstreetmap.org/node/7674311131

golf=hole should only be used on a way.

https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course#Features_within_a_golf_course

This rendering should be removed to discourage golf=hole being used as a node.
@imagico
Copy link
Collaborator

imagico commented Apr 8, 2023

This is probably based on the original implementation in the french style:

https://github.com/cquest/osmfr-cartocss/blob/9a7543eaee34fbb551e45550f3a14a7473639b17/sports.mss#L50

golf=hole is indeed practically not used on nodes (https://taginfo.openstreetmap.org/tags/golf=hole#overview) - so this should be changed.

@benjaco benjaco mentioned this issue Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue remove rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes amenity-points rendering for golf_hole benjaco/openstreetmap-carto
2 participants
@imagico @DaveF63