Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes amenity-points rendering for golf_hole #4857

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

benjaco
Copy link
Contributor

@benjaco benjaco commented Aug 11, 2023

Fixes #4804

Changes proposed in this pull request: Removes amenity-points rendering for golf_hole at all levels

Test rendering with links to the example places:

Left: Before / Right: After

Hi zoom (https://www.openstreetmap.org/node/7674311131)
Screenshot 2023-08-11 at 18 08 16
Lower zoom
Screenshot 2023-08-11 at 18 12 33
Keeps pins (https://www.openstreetmap.org/node/6287232319#map=16/50.8542/0.4474)
Screenshot 2023-08-11 at 18 12 45

Copy link
Collaborator

@imagico imagico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended.

If you feel like it i would also encourage you to look into #4862 and #4863. These are directly related to this change, i noticed them while testing.

@benjaco
Copy link
Contributor Author

benjaco commented Aug 16, 2023

@imagico, super
I'll have a look at them

@imagico imagico merged commit 445e553 into gravitystorm:master Aug 16, 2023
2 checks passed
@benjaco benjaco deleted the fix-4804 branch August 16, 2023 22:14
@imagico imagico mentioned this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is node golf=hole being rendered the same as golf=pin?
2 participants