Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point club:workshop is rendered as house number not icon in standard layer #4973

Closed
PeterOSM opened this issue May 27, 2024 · 8 comments
Closed

Comments

@PeterOSM
Copy link

Expected behavior

I expect a club to appear as the icon visible in the editor, shown in the attached picture. I experimented a little with tags but the problem seems to be related to the club item.

This is the point: https://www.openstreetmap.org/node/11923567693

Request

Render club with an icon and name in standard layer.

Actual behavior

The club appears as a house number from the address tag. The nearby atelier is rendered similarly. The point is visible only in some layers. In standard it is not consistently visible.

Screenshots with links illustrating the problem

  1. Tags
Screenshot 2024-05-27 at 11 00 50
  1. Point in editor rendering
Screenshot 2024-05-27 at 11 00 03
  1. Standard layer rendering
Screenshot 2024-05-27 at 11 01 39
  1. CyclOSM layer rendering
Screenshot 2024-05-27 at 11 03 24
@HolgerJeromin
Copy link
Contributor

Do you want to add rendering for
https://wiki.openstreetmap.org/wiki/Tag:amenity=workshop (548 uses)
or
club=workshop (exact ONE, your example)

@PeterOSM
Copy link
Author

PeterOSM commented May 27, 2024 via email

@HolgerJeromin
Copy link
Contributor

I think the club tag generally should be rendered for all values with no more specific icon as it appears in the editor properties.

That would be issue #4489 which was rejected for good reasons.

As an alternative amenity=workshop could be rendered.

This has right now far too few usages.

@PeterOSM
Copy link
Author

PeterOSM commented May 28, 2024 via email

@imagico
Copy link
Collaborator

imagico commented May 30, 2024

This touches a few matters previously discussed here:

You are right that the overall use of graphical symbology across projects relevant for mapping (in particular editors, tag documentation and OSM-Carto) is lacking in consistency. This has a number of different reasons.

  • OpenStreetMap is a highly decentralized project and there is no mechanism to enforce compliance to a uniform design standard, not even among different editors for example. This is widely consider a highly desirable situation (decentralization supporting diversity and innovation, making the project as a whole more robust and more able to adapt) - despite the negative aspects.
  • Maps and editors represent - in terms of graphics design as well as in the function symbols have - very different use cases with different constraints regarding symbol sizes, use of colors etc. This makes development of common symbology difficult.
  • Editor developers have - in general - different goals and interests than we have in OSM-Carto. This to some extent stems from the different function of the respective projects but also from their different histories and the different personal backgrounds and different economical situations of the project maintainers and developers.

That being said we try to look at what symbols are used elsewhere for the tags we render when adding or changing rendering. But this is primarily for inspiration, consistency in graphical representation with editors is not commonly a point we consider (for the reasons mentioned above). If you see concrete cases where this could be improved without sacrificing our goals we'd be interested in pointers. Simply documenting better how different editors symbolize different tags would also be valuable (not only for OSM-Carto but for OSM in general).

@PeterOSM
Copy link
Author

PeterOSM commented May 31, 2024 via email

@imagico
Copy link
Collaborator

imagico commented May 31, 2024

How do I or we close a case / question?

When you are logged in on github you can close your issues with the button on the bottom (next to the comment button).

@imagico imagico closed this as completed May 31, 2024
@PeterOSM
Copy link
Author

PeterOSM commented May 31, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants