Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should landcover be ordered by z_order? #53

Closed
gravitystorm opened this issue Jun 5, 2013 · 12 comments
Closed

Should landcover be ordered by z_order? #53

gravitystorm opened this issue Jun 5, 2013 · 12 comments

Comments

@gravitystorm
Copy link
Owner

At the moment the query orders by both z_order and way_area. Ordering by area makes sure small polygons end up on top (where there's no holes in a larger polygon). I guess z_order will help if the features are on separate layers, since there's no fine control over landcover ordering required.

But is this necessary? Are overlapping features with different z_orders - and the larger one on top - either common or wanted?

@pnorman
Copy link
Collaborator

pnorman commented Jun 11, 2013

Something small under a big field comes to mind, although I'm not 100% certain what landcover would be underneath.

@matthijsmelissen
Copy link
Collaborator

The most common case is probably underground parking.

Not sure what else this is relevant for?

@matthijsmelissen
Copy link
Collaborator

Piers are another example, see #330.

@matthijsmelissen
Copy link
Collaborator

See also #685.

@matthijsmelissen
Copy link
Collaborator

Are there any other examples for which this is relevant?

@daganzdaanda
Copy link

Similar to the examples in #685 are subway stations in Munich:
Stachus https://www.openstreetmap.org/#map=19/48.13970/11.56587&layers=N and to the east, at the Marienplatz.
Berlin Hauptbahnhof is pretty complicated:
https://www.openstreetmap.org/#map=18/52.52447/13.36974

@fgregg
Copy link

fgregg commented Jan 8, 2015

Here's another example: Big buildings above a large underground railway platform in Chicago:

https://www.openstreetmap.org/#map=19/41.87848/-87.63955

@matthijsmelissen
Copy link
Collaborator

In fact I think it's an example of #688. Neither buildings nor railway platforms are rendered by the landcover layer.

@matthijsmelissen
Copy link
Collaborator

Given that we haven't seen any usecase for ordering landcover by z_order in 2 years time, I will close this. Ordering of railway platforms etc. will still be considered, but these are not landcover.

@matthijsmelissen
Copy link
Collaborator

Now I look at this issue again, I see that my statement does not correspond to my action. I thought the current situation was that z_order (or layer) is not taken into account, but in fact it is. I still think it would be better not to take it into account, so the correct action, I think, would be to remove the layer column from the ORDER BY.

@kocio-pl
Copy link
Collaborator

Low zoom ordering has been removed in #2740, is it enough for us and the issue can be closed or we want to remove more of it?

@matthijsmelissen
Copy link
Collaborator

I think we also want to remove the z_order from the regular landuse query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants