-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render building=static_caravan as residential buildings #533
Comments
We will solve this issue by rendering the houses more heavy, rather than by rendering the caravans lighter. There is already a push request in place to accomplish that, see #490. I don't think a further fix is needed, so I will close this issue. |
2014-05-19 1:41 GMT+02:00 math1985 [email protected]:
IMHO a caravan (also "static" / "fix" ones) do qualify perfectly as light |
As I understand it from a fairly cursory read, #490 makes the relatively rare building=mobile_home (and maybe building:type=mobile_home too) (4024 instances in total, 825 of which are building=mobile_home) a light building, but containst nothing about the much more common (13397 instances, 3x as many) building=static_caravan tag. These objects are almost exactly the same thing: they are both forms of light prefabricated dwelling. They should be rendered as either lighter than houses, or at the same weight. They are both currently rendered heavier, and when #490 makes the live site, static_caravan will render at the same weight as a brick-and-mortar house but mobile_home will be lighter. (As it happens, I interpret "mobile_home"s as meaning "big prefabricated dwellings" and "static_caravan"s as meaning smaller prefab dwellings. The OSM wiki and Wikipedia equate the two, so don't trust my interpretation.) Please re-open this issue: its main concern has not been addressed. |
I agree, but please note that most building=static_caravan tags are added by the Dutch BAG import. I re-open the issue. |
Thanks, and thanks also for working on this. An overpass query (Wizard “"building:type"=mobile_home and source!=WakeGIS”) reveals that all 3199 "building:type=mobile_home"s are the result of the Wake County GIS (North Carolina, USA) import ☺ |
Replace the old buildings SQL and MSS. This involves resulting changes to landcover stylings to handle landcover which was previously in buildings.mss. Stops rendering supermarkets in a crazy pink to fix gravitystorm#520. Superceeds gravitystorm#550. Moves the rendering of train station areas to landcover. Fixes gravitystorm#327. Fixes gravitystorm#389 Removes outline differences based on a distinction that no one fully understands. Superceeds gravitystorm#533. Fixes gravitystorm#68
Replace the old buildings SQL and MSS. This involves resulting changes to landcover stylings to handle landcover which was previously in buildings.mss. Stops rendering supermarkets in a crazy pink to fix gravitystorm#520. Superceeds gravitystorm#550. Moves the rendering of train station areas to landcover. Fixes gravitystorm#327. Fixes gravitystorm#389 Removes outline differences based on a distinction that no one fully understands. Superceeds gravitystorm#533. Fixes gravitystorm#68
This has been solved in the meanwhile. |
Replace the old buildings SQL and MSS. This involves resulting changes to landcover stylings to handle landcover which was previously in buildings.mss. Stops rendering supermarkets in a crazy pink to fix gravitystorm#520. Superceeds gravitystorm#550. Moves the rendering of train station areas to landcover. Fixes gravitystorm#327. Fixes gravitystorm#389 Removes outline differences based on a distinction that no one fully understands. Superceeds gravitystorm#533. Fixes gravitystorm#68
Refactor buildings code Replace the old buildings SQL and MSS. This involves resulting changes to landcover stylings to handle landcover which was previously in buildings.mss. Stops rendering supermarkets in a crazy pink to fix #520. Superceeds #550. Moves the rendering of train station areas to landcover. Fixes #327. Fixes #389 Removes outline differences based on a distinction that no one fully understands. Superceeds #533. Fixes #68 Rebased in 6b2a4de by math1985 <[email protected]>
Could building=static_caravan (wiki, example) be rendered using the same residential style as for houses please? The outline is too heavy right now: compare the example to the surrounding houses.
Seems to be most common expression for the concept in Taginfo.
The text was updated successfully, but these errors were encountered: