Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for natural=saddle #718

Closed
matthijsmelissen opened this issue Jul 10, 2014 · 8 comments
Closed

Add rendering for natural=saddle #718

matthijsmelissen opened this issue Jul 10, 2014 · 8 comments

Comments

@matthijsmelissen
Copy link
Collaborator

The tag natural=saddle should be rendered with name and/or elevation, just like natural=peak.

See also https://trac.openstreetmap.org/ticket/4891.

@kocio-pl
Copy link
Collaborator

There's even the rendering hint and the icon on the wiki:

http://wiki.openstreetmap.org/wiki/Tag:natural%3Dsaddle#Appearance

@matthijsmelissen matthijsmelissen added this to the New features milestone Aug 18, 2014
@matkoniecz matkoniecz self-assigned this Sep 29, 2014
@matkoniecz
Copy link
Contributor

I would prefer to use 12px-mountain_pass_12x12_se svg after recolouring it to brown. (found at http://commons.wikimedia.org/wiki/Category:Mountain_pass_locator).

Unfortunately it would be necessary to use just this one for any saddle orientation.

The icon proposed on icon looks rather like some artificial contruction, like fort.

@matthijsmelissen
Copy link
Collaborator Author

Are all saddles passes?

@matkoniecz
Copy link
Contributor

Are all saddles passes?

Yes.

http://wiki.openstreetmap.org/wiki/Tag:natural%3Dsaddle comfirms this

This property marks a saddle point between mountains. Another name for saddle point is pass or mountain pass

@matkoniecz
Copy link
Contributor

OK, this icon is also not working. I see no good way to render saddles marked as nodes. Maybe just names without icons?

@matkoniecz matkoniecz removed their assignment Oct 10, 2014
@matkoniecz
Copy link
Contributor

Note that it conflicts with #244 - displaying both will result in duplicated names.

@nebulon42
Copy link
Contributor

I do not agree that all saddles are passes. A saddle is defined according to its elevation profile. Very often a saddle is also a mountain pass, but only when a way/path (highway=) passes through it. There is already the key mountain_pass= for marking a such a passage.

IMO a saddle should be rendered with an icon like proposed on the wiki (><), if it is tagged with mountain_pass=* then the icon should be >=< (JOSM does it already like that). Name and elevation if present should also be rendered. Since mountain_pass=* is not in the database I would leave out this conditional rendering for now.

@nebulon42
Copy link
Contributor

As #1096 got merged I think this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants