Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render mountain_passes #244

Closed
remontees opened this issue Oct 26, 2013 · 43 comments · Fixed by #4121
Closed

Render mountain_passes #244

remontees opened this issue Oct 26, 2013 · 43 comments · Fixed by #4121
Assignees
Labels

Comments

@remontees
Copy link

Is it possible to render on the openstreetmap moutain_passes with symbols like >=< ?

Thanks a lot!

@mrwojo
Copy link
Contributor

mrwojo commented Oct 27, 2013

12,203 uses per http://taginfo.openstreetmap.org/keys/mountain_pass

Technical issue: mountain_pass=* is not in the osm2pgsql style.

Technical caveat: There's some talk on the wiki doc of rendering the symbol in the direction of the way, however 99% of mountain passes are tagged on nodes (no direction).

@remontees
Copy link
Author

Yes… but?

@sabas
Copy link

sabas commented Oct 30, 2013

Also http://wiki.openstreetmap.org/wiki/Tag:natural%3Dsaddle could be rendered..

@simonpoole
Copy link

I don't think any fancy rendering is really necessary, name plus ele if present in brackets. For example "Pragelpass (1548)". Right now their is a tendency to add place nodes to display the name.

@gravitystorm gravitystorm added this to the 3.x - Needs upgrade to mapnik or openstreetmap-carto.style milestone Apr 29, 2014
@matkoniecz
Copy link
Contributor

Note that it conflicts with #718 - displaying both will result in duplicated names.

@matkoniecz
Copy link
Contributor

As natural=saddle rendering was added in #718 I will close this issue (reopened, but I think that displaying both natural=saddle and this feature is not a good idea - and natural=saddle is more general).

@simonpoole
Copy link

Closing this doesn't seem to make an awful lot of sense at this point in time.

There are ~14'000 mountain_pass tagged vs ~5000 saddles (from an importance pov a large number of the passes are -very- well known locations, contrary to saddles as natural features). Should a natural=saddle be added to each of the passes, or what is the proposed resolution?

@matkoniecz
Copy link
Contributor

Should a natural=saddle be added to each of the passes

For situations where it is saddle point - yes, it would be a good idea (technically, road may go through ridge not only through saddle points).

@kocio-pl
Copy link
Collaborator

Both are now about 20k uses and we have hstore already. The question is how should they be rendered?

@kocio-pl
Copy link
Collaborator

I guess replicating saddle rendering, but in transportation blue (similar to ford=* rendering) would be good.

@kocio-pl kocio-pl self-assigned this Oct 15, 2017
@jragusa
Copy link
Contributor

jragusa commented May 19, 2018

Several passes in the Alps comprise both natural=saddle and mountain_pass=yes(https://overpass-turbo.eu/s/yWl). What would be the correct colour in this case ?

@kocio-pl
Copy link
Collaborator

I still haven't decided. What would be your proposition?

@jragusa
Copy link
Contributor

jragusa commented May 19, 2018

That's a good challenge because 45% of mountain_pass comprise natural=saddle. I would propose to render both features in orange for simplicity. I'm also wondering whether it is really necessary to render differently mountain pass and saddle. I'm not sure that people point out the difference between them.

@matkoniecz
Copy link
Contributor

matkoniecz commented May 19, 2018

I am not convinced at all that displaying both "the highest point of a mountain way passing a crest" and "lowest point along a ridge or between two mountain tops" is a good idea.

Especially with the same symbol, it will strongly encourage people to start removing "duplicates".

@dieterdreist
Copy link

dieterdreist commented May 19, 2018 via email

@jragusa
Copy link
Contributor

jragusa commented May 20, 2018

Indeed, two colours (or shapes?) are needed for both features to avoid the removal of "duplicates". But in the case of hiking path, they are frequently close or on the same point which involves to define which feature has the priority.

@matkoniecz
Copy link
Contributor

Note that I reopened this issue after

Closing this doesn't seem to make an awful lot of sense at this point in time.

There are ~14'000 mountain_pass tagged vs ~5000 saddles (from an importance pov a large number of the passes are -very- well known locations, contrary to saddles as natural features). Should a natural=saddle be added to each of the passes, or what is the proposed resolution?

At this moment we have 25k of each feature (see https://taginfo.openstreetmap.org/keys/mountain_pass and https://taginfo.openstreetmap.org/tags/natural=saddle ).

Given that rendering both makes no sense at all and would be highly confusing I plan to close this issue again.

@kocio-pl
Copy link
Collaborator

Both are different, so I think rendering mountain_pass with transport blue and saddle with peak orange will show it. When both are tagged (11 363 cases, 45% of saddles - see https://taginfo.openstreetmap.org/tags/natural=saddle#combinations), we could show orange symbol - I think it's more generic than transport.

@matkoniecz
Copy link
Contributor

I think rendering mountain_pass with transport blue

I am not convinced that it is a good idea. What would be purpose of showing it?

@kocio-pl
Copy link
Collaborator

They are known orientation points, with name and its own elevation, which might be different than saddle - look at this example:

https://www.openstreetmap.org/node/1672555752#map=18/49.41742/21.69584
https://www.openstreetmap.org/node/5255771803#map=18/49.41747/21.69598

@tsk1979
Copy link

tsk1979 commented Sep 22, 2018

Mountain passes are important features on motorable roads in the Himalayas and some are even tourist destinations. Some for adventurers. A community mapping them wanted to use google custom map, but I told them OSM, but there is no way to do it. I guess saddle is what we need to do? But that is wrong

@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 22, 2018 via email

@kocio-pl
Copy link
Collaborator

I still have no clear idea how should they be rendered. Design decision is needed.

@tsk1979
Copy link

tsk1979 commented Sep 23, 2018

Thanks guys. I now understand it somewhat. But I am not a very experienced mapper, and I have taken it upon myself to map all motorable passes of ladakh region. I want to map such that anybody downloading openstreetmap through OSM etc., can see those and navigate to them. Please advise what I should do now.

@kocio-pl
Copy link
Collaborator

If you mean downloading maps for Garmin-like devices, they have their own styles of showing data. Maybe they are showing passes already, I don't know because I don't use them.

If you mean showing on default map, we need to know how should they look like - which color, which icon (if any)? How would they look comparing to saddles? This is what we need to decide and discuss.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 23, 2018 via email

@tsk1979
Copy link

tsk1979 commented Sep 24, 2018

Go to openstreetmap.org and search for "kakasang la"

The exact location is
http://www.geonames.org/maps/browse_33.434787_78.559313.html

In the Overland community high altitude passes are important landmarks.
So we need

  1. Icon for a mountain pass
  2. Altiutude
  3. Name

The popular applications which use OSM on android phones are OSMAND and mapfactor Navigator + Gaia maps etc.,

If I search for kakasang la on openstreetmap,org it takes me to that point on road, but nothing is marked there.

Its more like a landmark (eg a vista point). So I guess it should be mapped as a waypoint with attributes of
name, altitude, and motorable:yes/no. Some passes are hikes only

@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 25, 2018 via email

@mboeringa
Copy link

Does anyone know if this code, to align an icon with the parent "way", is feasible to implement in this style?

It is much easier if users finally start adding useful information by entering the OSM direction=x tag, as I have done in some limited areas. That tag can then be used to rotate a point feature, which is relatively easy in most rendering frameworks. Also, having looked at some of the involved mountain paths (versus true motorcar highway=x elements), I think automatic aligning may give sub-standard results due to jaggy path lines. This last thing is less of a problem with true highways that tend to be more smooth.

@mboeringa
Copy link

By the way, AFAIK OpenTopoMap does not align the mountain pass symbol to a way element, but to a DEM, in a pre-processing step that calculates the missing direction=x field, which is a sophisticated but complex method certainly not feasible for many styles.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 25, 2018 via email

@tsk1979
Copy link

tsk1979 commented Sep 25, 2018

Have you confirmed the location of this pass with GPS or survey in person, @tsk1979?

Yes, in Person
I geotagged image also
N33.434787 E78.559313

Symbol is like a bridge. Here : https://wiki.openstreetmap.org/wiki/File:Geomorphology_vosges.png

@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 25, 2018 via email

@tsk1979
Copy link

tsk1979 commented Sep 25, 2018

There is high rez png here on wikimedia. Can that be used @jeisenbe
https://commons.wikimedia.org/wiki/File:Mountain_pass_12x12_n.svg

@ppete2
Copy link

ppete2 commented Jan 21, 2019

I'm missing the rendering of mountain_pass=yes in OSM carto very much. Many other tiny POIs are rendered in OSM carto. But still not such - often well known - landmarks like mountain_passes of roads or ways?

Yes, often mountain_passes are running over a natural=saddle. But not always, and those which don't actually are missing in OSM carto. And even the Wiki says "OpenStreetMap clearly differentiates between these two concepts". Saddle is a point defined by landscape, nature. mountain_pass is part of a (man-made) way, for example a road. So both things should be rendered too.

A good example where a mountain-pass is not equal to the saddle point has been already mentioned above:
#244 (comment)

How to render?

Symbol:
Also already mentioned, something like https://commons.wikimedia.org/wiki/File:Mountain_pass_12x12_n.svg , similar signs are usually used on topografic maps to indicate passes: https://wiki.openstreetmap.org/wiki/Talk:Tag:mountain_pass
No need to complex calculate rotation. Always either vertical, horizontal or diagonal as the basic .svg is.

Text:
Should contain name + elevation

Color:
should be different from natural=saddle to be easy distinguishable.

Priority:
what to render if saddle and mountain_pass share the same node. Or are (depending on zoom level) very close to each other: No need to introduce a third symbol or a third color.
Just draw the mountain_pass, since it is perhaps more in common use to most of the people than the natural saddle point. For example people which are using the map for plannig road-trips or hiking trips.

@kocio-pl
Copy link
Collaborator

Would you like to prepare the code implementing this proposition? That gives the biggest chance to have this feature rendered.

@ppete2
Copy link

ppete2 commented Jan 21, 2019

Sorry, I'm just an OSM editor and user of maps who supports the other users in this thread with ideas how to implement mountain_pass rendering.
But I have no knowledge of Rendering, CartoCSS, Mapnik and the necessary coding stuff.

@jragusa
Copy link
Contributor

jragusa commented Jan 21, 2019

It's related to transportation, so the blue colour of @transportation-icon would be suitable. An other problem is that some "pass" has both mountain_pass=yes and saddle=yes, which one would have the priority ?

@Adamant36
Copy link
Contributor

It sounds like from the wiki that they are different things and mapped seperately. So if they do overlap its probably rare. Id say treat the instances where they do like ever other overlapping feature and go with whatever icon is first in rendering priority. One could also be set to render a zoom level sooner, but I'm not sure with would be more important (although id think it would probably be the natural feature).

@jragusa
Copy link
Contributor

jragusa commented Jan 21, 2019

It's the case if you consider paths and sometimes also tracks or because the saddle is narrow. Moreover the saddle was used as mountain_pass in the past since it's the easier way.

@matthijsmelissen
Copy link
Collaborator

If the choice is between rendering saddles or mountain passes, I'd favour the latter. Mountain passes always have relevance, while there are many saddle points that are hardly interesting.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jan 22, 2019 via email

@Adamant36
Copy link
Contributor

If you see a road or path that crosses a saddle, then you know that
saddle is also a pass, by definition.

I was totally thinking that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.