Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

place_of_worship too prominent on low zoom #93

Closed
tyrasd opened this issue Aug 4, 2013 · 8 comments · Fixed by #293
Closed

place_of_worship too prominent on low zoom #93

tyrasd opened this issue Aug 4, 2013 · 8 comments · Fixed by #293

Comments

@tyrasd
Copy link
Contributor

tyrasd commented Aug 4, 2013

The fill colour of churches, etc. looks too dark on low zooms. See this example:

zoom level 14:
zoom14

zoom level 15:
zoom15

@mrwojo
Copy link
Contributor

mrwojo commented Nov 2, 2013

The darkness shift is very noticeable on large areas: http://www.openstreetmap.org/browse/way/179086480

@dieterdreist
Copy link

2013/8/4 Martin Raifer [email protected]

The fill colour of churches, etc. looks too prominent on low zooms.

I don't agree. Churches are one of the main features for orientation in
christian countries and traditionally very prominent in maps, for good
reason IMHO.

@tyrasd
Copy link
Contributor Author

tyrasd commented Nov 3, 2013

The problem is that place_of_worship gets fairly darker between zoom 15 and 14, which is a quite singular effect in the osm-carto stylesheet:

Note that this wasn't the case in the original osm-mapnik stylesheet:


(compare)

@dieterdreist
Copy link

Am 03/nov/2013 um 09:51 schrieb Martin Raifer [email protected]:

The problem is that place_of_worship gets fairly darker between zoom 15 and 14, which is quite singular in the osm-carto stylesheet:

maybe it would be better to focus on building=church (etc.)? Or pow AND building=yes

@pnorman
Copy link
Collaborator

pnorman commented Nov 4, 2013

Definitely a change from osm.xml. @gravitystorm, know if this was intentional?

@mrwojo
Copy link
Contributor

mrwojo commented Nov 4, 2013

It appears to be a side-effect of polygon-clip: false in the #buildings-lz layer. The fill is compositing with gray rather than the actual underlying color. The 0.5 opacity allows the gray to show through.

The Carto-generated Mapnik XML contains this unfiltered rule for this layer:

  <Rule>
    <MaxScaleDenominator>750000</MaxScaleDenominator>
    <PolygonSymbolizer clip="false" />
  </Rule>

Gray is indeed the default fill for a polygon symbolizer.

@vincentdephily
Copy link

Note that "building=church" is quite orthogonal to "amenity=place_of_worship". The church building could have been deconsecrated and even, as seen in Ireland, turned into a pub, a tourist office, or a carpet shop (!). There is also the case of smaller religions or communities that hold their religious activities in a standard house.

@dieterdreist
Copy link

2013/11/5 vincentdephily [email protected]

Note that "building=church" is quite orthogonal to
"amenity=place_of_worship". The church building could have been
deconsecrated and even, as seen in Ireland, turned into a pub, a tourist
office, or a carpet shop (!).

Yes, I am fully aware of that, and my suggestion to concentrate on
building=church etc. reflects this. The main purpose of highlighting
churches (IMHO) in a map is that they serve for orientation, like the
townhall (and eventually the marketplace) they denote the center of the
village/town (often, in big cities they might also indicate the former
borders, as they were placed at the limits in order to make the burials
outside of the city), generally they had a huge influence on how the
city/town evolved through the centuries, and this importance is mostly
still present in the city structure, even if in some cases nowadays they
are not sacred any more. To put it short: the building church / aka former
location of a place of worship is generally more important than actual
places of worship (for most map makers and map consumers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants