Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move museum icon to SVG #1174

Merged
merged 1 commit into from
Jan 2, 2015
Merged

Conversation

nebulon42
Copy link
Contributor

Implements part of #1165 and moves tourism=museum to SVG.
Icon can be found here: https://github.com/nebulon42/osmic/blob/master/tourism/museum-16.svg

http://www.openstreetmap.org/#map=19/46.79838/13.49323
before:
museum_before

after:
museum_after

@nebulon42 nebulon42 changed the title moved museum icon to SVG move museum icon to SVG Dec 22, 2014
<path
d="M 8,2 2,4 14,4 8,2 z m -6,3 0,1 1,0 0,6 -1,0 -1,2 14,0 -1,-2 -1,0 0,-6 1,0 L 14,5 2,5 z M 6,6 7,7 7,12 5,12 5,7 6,6 z m 4,0 1,1 0,5 -2,0 0,-5 1,-1 z"
id="path2988"
style="fill:#1a1a1a;fill-opacity:1;stroke:none" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you shouldn't specify a fill since it's coming from marker-fill in the MSS. None of the other style attributes are necessary either

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from Inkscape, unfortunately (except the fill). I don't think it is feasible to edit all the sources and I didn't notice problems with the fill. For me these are subtleties, but I can change it if you think it is better.

@pnorman
Copy link
Collaborator

pnorman commented Dec 23, 2014

what do you think of this?

<?xml version="1.0" encoding="UTF-8"?>
<svg xmlns="http://www.w3.org/2000/svg" width="100%" height="100%" viewBox="0 0 16 16">
<path d="M 8,1 2,3 2,4 14,4 14,3 Z
M 1,14 2,12 14,12 15,14 Z
M 2,5 2,6 3,6 3,12 13,12 13,6 14,6 14,5 Z
M 5,12 l 0,-5 a 1,1 0 0,1 2,0 l 0,5 Z
M 9,12 l 0,-5 a 1,1 0 0,1 2,0 l 0,5 Z"/>
</svg>

image
(pixel grid added)
I think it balances the weight of the top and bottom better

@nebulon42
Copy link
Contributor Author

Definitely an improvement. Maybe we should also make it less tall then?
bildschirmfoto vom 2014-12-23 21 30 59

The spiky areas between the columns where intended to look more crisp, but I'm not sure if that is necessary.

This was referenced Dec 23, 2014
@pnorman
Copy link
Collaborator

pnorman commented Dec 25, 2014

Maybe we should also make it less tall then?

That might be a good idea.

The spiky areas between the columns where intended to look more crisp, but I'm not sure if that is necessary.

At 1x resolution the difference is between them being 50% gray pixels and 25% gray pixels, no sharpness difference.

I think the curves will look better for 2x and print. For 2x the line is

1.0 0.5 0.5 1.0
0.5 0.0 0.0 0.5

and the curve is

1.0 0.2 0.2 1.0
0.2 0.0 0.0 0.2

@nebulon42
Copy link
Contributor Author

Good argument, I have updated the icon.

@matthijsmelissen
Copy link
Collaborator

Looks nice!

@mboeringa
Copy link

Looks nice!

Agree, simple but effective.

gravitystorm added a commit that referenced this pull request Jan 2, 2015
@gravitystorm gravitystorm merged commit 1eff739 into gravitystorm:master Jan 2, 2015
@nebulon42 nebulon42 deleted the svg-museum branch January 2, 2015 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants