-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move museum icon to SVG #1174
move museum icon to SVG #1174
Conversation
db4ee90
to
6e24975
Compare
<path | ||
d="M 8,2 2,4 14,4 8,2 z m -6,3 0,1 1,0 0,6 -1,0 -1,2 14,0 -1,-2 -1,0 0,-6 1,0 L 14,5 2,5 z M 6,6 7,7 7,12 5,12 5,7 6,6 z m 4,0 1,1 0,5 -2,0 0,-5 1,-1 z" | ||
id="path2988" | ||
style="fill:#1a1a1a;fill-opacity:1;stroke:none" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you shouldn't specify a fill since it's coming from marker-fill
in the MSS. None of the other style attributes are necessary either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from Inkscape, unfortunately (except the fill). I don't think it is feasible to edit all the sources and I didn't notice problems with the fill. For me these are subtleties, but I can change it if you think it is better.
That might be a good idea.
At 1x resolution the difference is between them being 50% gray pixels and 25% gray pixels, no sharpness difference. I think the curves will look better for 2x and print. For 2x the line is
and the curve is
|
6e24975
to
48f680e
Compare
Good argument, I have updated the icon. |
48f680e
to
bee73a5
Compare
Looks nice! |
Agree, simple but effective. |
Implements part of #1165 and moves
tourism=museum
to SVG.Icon can be found here: https://github.com/nebulon42/osmic/blob/master/tourism/museum-16.svg
http://www.openstreetmap.org/#map=19/46.79838/13.49323
before:
after: