Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move recycling icon to SVG #1175

Merged
merged 1 commit into from
Jan 2, 2015

Conversation

nebulon42
Copy link
Contributor

Implements part of #1165 by changing the icon for amenity=recycling to SVG (as requested by @mkoniecz in #1012). This should be an easy one as the symbol (recycling-16.svg) did not change.

http://www.openstreetmap.org/#map=19/48.19712/16.40279
before:
recycling_before

after:
recycling_after

@nebulon42 nebulon42 mentioned this pull request Dec 24, 2014
66 tasks
@pnorman
Copy link
Collaborator

pnorman commented Dec 25, 2014

Do the fine lines of the arrowhead and the thin gaps at the corners work for 16px size?

@nebulon42
Copy link
Contributor Author

Not really well, but I have experimented a lot and was not able to come up with a better version. This is the closest I got: recycling-16.svg

I'm open for improvements though. Maybe we can also replace the icon for #1012 first and subsequently improve it.

@matthijsmelissen
Copy link
Collaborator

Do you have a rendering demo for this one?

@nebulon42
Copy link
Contributor Author

Not much has changed, see above.

@pnorman
Copy link
Collaborator

pnorman commented Dec 30, 2014

Not really well, but I have experimented a lot and was not able to come up with a better version. This is the closest I got: recycling-16.svg

Ya - the recycling symbol is hard to do in low res. There's been a lot of effort done to make it work with plastic molding, but I'm not aware of much with rasterized images.

The recycling symbol would be a good use case for drawing a third and rotating it, except Mapnik doesn't support that.

gravitystorm added a commit that referenced this pull request Jan 2, 2015
@gravitystorm gravitystorm merged commit 9b1cc41 into gravitystorm:master Jan 2, 2015
@nebulon42 nebulon42 deleted the svg-recycling branch January 2, 2015 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants