Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding highway=elevator icon (only for public elevators) #1629

Merged
merged 1 commit into from
Jul 26, 2015

Conversation

kocio-pl
Copy link
Collaborator

@kocio-pl kocio-pl commented Jul 2, 2015

Resolves #720.

elevator-12-z19
elevator12-z19-tarasy

It also fixes double bus_stop appearance in project.yaml.

@nebulon42
Copy link
Contributor

I think it is a bit too lightweight. Maybe try to make that elevator box solid and subtract the arrows from that shape (like the cross in pharmacy).

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Jul 5, 2015

Sounds interesting - I will try this idea.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Jul 5, 2015

I doubt it's any better:
elevator-z19-solid-gdanski
elevator-z19-centralny

@ximex
Copy link

ximex commented Jul 23, 2015

the first version looks better but is very hard to see in pic1. Sooo i think version 2 is better...

@kocio-pl
Copy link
Collaborator Author

I think 3) could be sane compromise, because 2) is harder to recognize for me and this one is visible even in such a cluttered place:
elevator-11-gdanski
elevator-11-centralny

@kocio-pl kocio-pl mentioned this pull request Jul 25, 2015
matthijsmelissen added a commit that referenced this pull request Jul 26, 2015
Adding highway=elevator icon (only for public elevators)
@matthijsmelissen matthijsmelissen merged commit 512cf27 into gravitystorm:master Jul 26, 2015
@matthijsmelissen
Copy link
Collaborator

The proposed version looks fine to me. If anything can be improved, feel free to write a next PR.

@kocio-pl kocio-pl deleted the elevator-icon branch July 26, 2015 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rendering for elevators
4 participants