Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding amenity=social_facility icon #1776

Merged
merged 1 commit into from
Feb 9, 2016

Conversation

kocio-pl
Copy link
Collaborator

Implements part of #108.

I think we should render amenity=social_facility the same as amenity=community_centre in general. Once we have social_facility=* key available, we can create also some more specific icons (for shelters or food-related places, for example).

social_facility-19

@matkoniecz
Copy link
Contributor

I think that for this two amenities just label would be better.

@kocio-pl
Copy link
Collaborator Author

Hm, since more than 93% such objects have a name it is perfectly acceptable solution, however I also know the place which is a mix of few different social facilities in one building with the enclosing area, so it would be still not visible.

Your proposition would only change the color for social facilities enclosed in one building to brown (about 19%) and start to show the names of the rest. Even in the worst case (assuming that all the buildings already have names) we would show 74% currently invisible such objects, so it would be quite effective.

I still like this icon to be used, but I'm not going to argue if more people doesn't like my POV.

BTW: or we could also use some borders with name labels, maybe? This would show all the social facilities, irrespective of them being named or not, but I'm not sure how the border should look like and if it is not overkill in general (but for some places like orphanage it would be natural to show the area, like we do for schools).

More opinions and ideas would probably help.

@kocio-pl
Copy link
Collaborator Author

After some discussion on #660 now I feel that displaying the icon with text is preferable over just the label, because it makes this style more universal (icons are language independent) while not obscuring other things (high zoom level is not crowded).

@polarbearing
Copy link
Contributor

Label and icon please. Some objects can have fancy names which do not reveal what they are. I mapped one called "The Gap".

@kocio-pl
Copy link
Collaborator Author

I've just made a special draft for this type of facility:

  1. social_facility-14-29
  2. social_facility-14-30

@polarbearing
Copy link
Contributor

@kocio-pl - good one. Could be seen as 'helping hand' as well as 'cocooning' which both leads to the intended association.

@matthijsmelissen
Copy link
Collaborator

I haven't had time to look at this yet.

@kocio-pl
Copy link
Collaborator Author

I think new icon really makes sense and it's definitely better to have something different than community centre icon if possible:
social-facility-hands-19

@polarbearing
Copy link
Contributor

Progress in this issue would be appreciated, does anything speak against the icon?

@matthijsmelissen
Copy link
Collaborator

When I see the community centre icon on the map, it keeps reminding me of a school rather than a community centre? Am I'm the only one in that?

Also, I'm not sure if the current icon expresses for example a nursing home very well?

I'm not necessarily against, but also not strongly in favour of this icon.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Nov 9, 2015

Looks like nursing home is tagged differently (amenity=nursing_home), however it's not clear which scheme is preferable.

@polarbearing
Copy link
Contributor

social_facility 40000 currently. Nursing home is the older style for tagging a subclass of social_facility.

We should discuss the community_centre icon in the other issue, and focus her on the later social_facility proposal by @kocio-pl Sep 24-28.

@polarbearing
Copy link
Contributor

@math1985 - it is not clear what icon your comments on Nov 9 refer to.

The PR currently implements the 'helping hand' icon from @kocio-pl, not the community centre one.

@mboeringa
Copy link

I've just made a special draft for this type of facility:

  1. alt text
  2. alt text

Nice ones, I think I have a slight preference for the hands which bend inwards. This looks more natural, and makes the hands both more recognizable as such, and more "caring".

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Jan 3, 2016

@mboeringa I took 1) because 2) looks blurred for me and I personally have more trouble recognizing the shape alone, but I was trying to achieve exactly what you say.

@matthijsmelissen
Copy link
Collaborator

I'm still not extremely fond of the icon, but I think it's better than nothing, so I'll accept this PR.

@matthijsmelissen
Copy link
Collaborator

Sorry, I didn't see the icon was changed with respect to the preview. New icon looks fine to me!

@matthijsmelissen matthijsmelissen merged commit 7d9e187 into gravitystorm:master Feb 9, 2016
matkoniecz added a commit to matkoniecz/CartoCSSHelper that referenced this pull request Feb 9, 2016
@kocio-pl kocio-pl deleted the social_facility branch February 9, 2016 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants