render labels for named barriers

[matkoniecz]

Done to handle case reported in #1824

I am not sure whatever it should be changed to ignore polygons. On one hand it will ignore closed ways (and some are valid), on the other hand things like tagging landuse with name and barrier on one object is common.

I am not sure whatever this poor tagging should result in a poor rendering.

https://cloud.githubusercontent.com/assets/899988/16034062/e5364a66-320f-11e6-80da-b113c257d7d0.png
https://cloud.githubusercontent.com/assets/899988/16034070/eae4594e-320f-11e6-8c6e-8f769dc3cf25.png
https://cloud.githubusercontent.com/assets/899988/16034045/d1569e10-320f-11e6-8270-13a91b3dc952.png

[matkoniecz]

This branch has conflicts that must be resolved

That was not expected, but in this case it is useful - this one should not be merged too quickly. It will make map worse in many places and the question is whatever doing that for this type of poor tagging is desirable.

[matkoniecz]

Previous try - see #1885

[matkoniecz]

To see how common area+barrier+name problem is see http://overpass-turbo.eu/s/gME (it finds only the most obvious problems - if somebody run out of problems to fix I may make one that is capable of finding all problems).

[dieterdreist]

sent from a phone

Il giorno 14 giu 2016, alle ore 09:11, Mateusz Konieczny [email protected] ha scritto:

I am not sure whatever it should be changed to ignore polygons. On one hand it will ignore closed ways (and some are valid), on the other hand things like tagging landuse with name and barrier on one object is common.

I am not sure whatever this poor tagging should result in a poor rendering.

IMHO we should not encourage or endorse broken mapping like barrier=wall landuse=cemetery on the same object.

[dieterdreist]

sent from a phone

Il giorno 14 giu 2016, alle ore 09:21, Mateusz Konieczny [email protected] ha scritto:

To see how common area+barrier+name problem is see http://overpass-turbo.eu/s/gME

if we start to highlight the problem by showing names on these linear barriers as well (or maybe even show the whole area as barrier) we can be confident that people will clean it up quickly

[jojo4u]

Apart from violating the rule "one feature - one osm element" what data problems does the style have with this type of tagging?

[dieterdreist]

sent from a phone

Il giorno 14 giu 2016, alle ore 10:42, jojo4u [email protected] ha scritto:

Apart from violating the rule "one feature - one osm element" what data problems does the style have with this type of tagging?

the problem is that you don't know:

• which tag belongs to which object
• whether the feature is intended to be linear or a polygon (in some cases, like barriers)

[matkoniecz]

whether the feature is intended to be linear or a polygon (in some cases, like barriers)

And this data problem was already reported as style problem, see #971

[pnorman]

👎 to anything which treats the same object as both a line feature and a polygon feature

[dieterdreist]

2016-06-14 23:15 GMT+02:00 Paul Norman [email protected]:

👎 to anything which treats the same object as both a line feature and a
polygon feature

while I agree with this position, it should be actively communicated to the
community IMHO, because a lot of people do indeed map in a way where both,
linear and polygonal features, are mapped to the same OSM object,
especially barriers.

[SomeoneElseOSM]

@dieterdreist The place to do that is probably on http://wiki.openstreetmap.org/wiki/One_feature,_one_OSM_element . That's I refer people to, and I suspect that others do too. Also, of course raise it with new mappers in changeset discussions.

[matkoniecz]

@pnorman

👎 to anything which treats the same object as both a line feature and a polygon feature

Is it rejection of [barrrier=* + landuse=*] tagging or is it rejection of this rendering? Or both?

[matthijsmelissen]

Is it rejection of [barrrier=* + landuse=*] tagging or is it rejection of this rendering? Or both?

barrier=city_wall + landuse=retail on a closed linestring should be interpreted as a polygon that is both a city wall and a retail area (i.e. a big city wall tagged as polygon with shops inside).

The rendering should match that interpretation.

I'd recommend waiting with this issue until the database reload, because this might change things.

[pnorman]

I'd recommend waiting with this issue until the database reload, because this might change things.

I don't see that it'll change things, since it'll still be a polygon (or not).

The technical implementation of this is that there's a function which, given the tags of an object, tells you if it is a polygon or not.

[matkoniecz]

@pnorman What is your opinion about rendering names solely for lines?

[pnorman]

4M barriers, 17k named.

Selecting random ones I see a mix of descriptions and actual names. Most of the named ones old.

The problem is going to be coming up with a suitable style, and I have no ideas there.