Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing borders color to gray [WIP] #2695

Closed
wants to merge 1 commit into from

Conversation

kocio-pl
Copy link
Collaborator

@kocio-pl kocio-pl commented Jul 22, 2017

Related to #622.
Related to #3526.

Simple color change for the borders from violet to gray. Examples:

Warsaw, z12
Before
af5zg3i3
After
huj_btnw

Europe, z4 (see more examples here)
Before
ubx5_svd
After (borders)
7uehxsqz
After (borders+water)
negfihhr

@HolgerJeromin
Copy link
Contributor

Crowded city centers would be interesting

@Tomasz-W
Copy link

It looks very good on low- and mid-zooms, but I'd like to see some high-zoom examples, especially places where borders crosses or goes along other elements of map

@kocio-pl
Copy link
Collaborator Author

Could you give some examples to test?

@kocio-pl
Copy link
Collaborator Author

The most convenient would be something included in Metro extracts.

@imagico
Copy link
Collaborator

imagico commented Jul 22, 2017

The most serious problem at the low/mid zooms with grayish borders is interference with railways at z7 and above.

The German style using a somewhat greenish tone (much less green though than the old German style) is doing a bit better here but not really great:

https://mc.bbbike.org/mc/?lon=9.948721&lat=51.108173&zoom=7&num=2&mt0=mapnik-german&mt1=mapnik

At the high zooms you are also going to have interference with cliff:

https://mc.bbbike.org/mc/?lon=6.745563&lat=46.339865&zoom=13&num=2&mt0=mapnik-german&mt1=mapnik

cc @giggls.

@matthijsmelissen
Copy link
Collaborator

Note that this partially reverts #1749 / 5a0f036 .

@kocio-pl kocio-pl changed the title Changing borders color to gray Changing borders color to gray [WIP] Jul 22, 2017
@kocio-pl
Copy link
Collaborator Author

Thanks for raising these issues. Borders rework may include different pattern and changing levels like it's discussed in #622. I'd like to start with extending new midzoom landuse colors for low zoom to see how they will interact with borders. Green is unlikely (there will be more trees), but maybe gray+violet tint could work?

@nebulon42 wants to publish lowzoom tool which will save z8 landuses, so testing can take only reasonable time.

@kocio-pl
Copy link
Collaborator Author

There are many other changes related to midzoom going right now, so I close this PR. Borders needs probably more in-depth discussion anyway than this trivial color change.

@kocio-pl kocio-pl closed this Aug 11, 2017
@kocio-pl kocio-pl deleted the border-color branch August 11, 2017 18:13
@kocio-pl
Copy link
Collaborator Author

@imagico On the other hand we have other confusing things currently: #1248.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants