Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move emergency=phone to higher zoom level #2993

Merged
merged 1 commit into from
Jan 22, 2018

Conversation

kocio-pl
Copy link
Collaborator

@kocio-pl kocio-pl commented Dec 22, 2017

Related to #1745 and #1884.

Emergency phones are really small scale, special features and I'm not even sure if they belong to general map - probably not, but even if they do, they should be rendered later, because proper tagging results in z17 clutter:

Example place on z17:

Before
feoc_qbo
After
g6tcvoqd

@SomeoneElseOSM
Copy link
Contributor

Does this density usage of emergency=phone appear elsewhere? It seems pretty unusual. Certainly in the UK a typical emergency phone wold be beside a motorway a long distance from the next one. In another map style I've rendered emergency phones from z17 for a while (see e.g. https://map.atownsend.org.uk/maps/map/map.html#zoom=17&lat=52.870968&lon=-1.39329 ) and I've never thought "there are too many of them".

Is this perhaps another "Polish graveyard" - making one standard map work well in one specific location means that it works less well everywhere else on the planet?

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Dec 22, 2017

Let's start with checking the reasons to show emergency phone on the general map at all, if this is related mostly to motorways:

  • This is not a car map, so car related features should not be elevated.
  • In journey one uses rather GPS mobile devices and apps with vector data or paper maps (both of which might have such points visible), not the standard raster map.
  • One does not preview areas for emergency devices, their location should be signed and highlighted on the ground.

The main thing that is pro rendering is showing diversity of objects in OSM (database preview). That's why I propose z19, not just to stop rendering them, but even on this zoom level they are still a problem in this campus IMO. Another pro is that they are shown for a long time (although the rendering changed and I provided the code which shows the new tagging scheme lately - #2809).

Is this perhaps another "Polish graveyard" - making one standard map work well in one specific location means that it works less well everywhere else on the planet?

What was the story about "Polish graveyard"? I don't remember the issue.

I'm not sure how many such places might be, unfortunately I have no tools to find "dense cluster of x". This is however the illustration of the problem when somebody is motivated enough to map them carefully.

I guess most of the emergency features (such as phones, fire extinguishers, hydrants, sirens, defibrillators or assembly points) do not suit here well, at least not until very late zoom levels, when you may want to see detailed plans of some places. It's hard for me to find exceptions - ambulance station is rather big, but that can be shown simply as a building.

@dieterdreist
Copy link

dieterdreist commented Dec 22, 2017 via email

@matkoniecz
Copy link
Contributor

What was the story about "Polish graveyard"? I don't remember the issue.

Maybe it is about mapping of all alleys and footways in cemetery, rather than only cemetery area that encourages rendering changes that result in worse maps in areas where footways are rare and tend to be important (mountains, rural areas)?

@turnsole80
Copy link

Yes, I think emergency phones should still be rendered, since they cover all types, and not just those used on highways.

That said, changing them to appear at a higher zoom seems like a perfectly fine idea.

@dieterdreist
Copy link

dieterdreist commented Dec 23, 2017 via email

@kocio-pl
Copy link
Collaborator Author

It is always good to have some classification of objects, however good classification is not always easy to design. For example "war memorial" and "stone" values share the same memorial=* sub-key, which is unfortunate mix of the common forms and the common functions.

For rendering the most important property seems to be urban/rural location, but it's rather contextual problem than category problem and we need to detect it, probably using some form of pre-computing (see #1957 and https://github.com/SK53/ua2/ ). When the highway goes through the city, the emergency=phone + phone_context=highway should be probably rendered later then the same phone when going through the rural area.

Real life example: this motorway junction label competes with a city district name and some other junction labels, which is bad, while outside the city the same zoom level is OK.

@dieterdreist
Copy link

dieterdreist commented Dec 24, 2017 via email

@kocio-pl
Copy link
Collaborator Author

Yes, this is partially a tagging problem - the mapper should not be pushed to choose highway/urban context if both are true, that's exactly what I said about how hard it is to design proper subtags.

But it's a more general problem anyway that almost any kind of object outside the urban context should be rendered earlier, yet no one expects people to tag "urban=yes/no" for junctions, fuel stations, restaurants, motels and other highway related POIs (but also crosses, shrines, shops, towers and so on).

@dieterdreist
Copy link

dieterdreist commented Dec 24, 2017 via email

@kocio-pl kocio-pl merged commit 5b2b410 into gravitystorm:master Jan 22, 2018
@kocio-pl kocio-pl deleted the emergency-phone-later branch January 22, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants