Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move barriers to higher zoom level #3157

Merged
merged 1 commit into from
Apr 30, 2018

Conversation

kocio-pl
Copy link
Collaborator

Fixes #323

Changes proposed in this pull request:

  • moving barriers from z16+ to z17+:
    • gate
    • lift_gate
    • swing_gate
    • bollard
    • block
    • log

Test rendering with links to the example places:

Example place with gates, z16
Before
nfawmamh

After
i_bplp2q

Example place with bollards, z16
Before
ndz77k9j

After
blsw9wd_

Example place with gates and lift gates, z16
Before
qtc tyij

After
sew4co2j

@dieterdreist
Copy link

dieterdreist commented Apr 1, 2018 via email

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Apr 2, 2018

There are few important reasons which make me think this change is needed:

  1. We have more data added and what was not a problem in the beginning (just show whatever is added), now became the source of a mess. We have more well-mapped areas ("WMA") and as you can see in case of Cles (Italy) even typical medium-sized town, which I think was a target model when inventing and rendering many tags, can look bad now, just because somebody did her job well. This is not kind of a feedback mappers should have - we should rather encourage them to add more, showing that we can handle it properly.

  2. When making universal (not thematic) style the main slogan should be "mind the scale", because there are too many things to prioritize. The only easily observable thing is a typical size of a feature and this is a rule of thumb when I think about initial zoom level. Point barriers are usually small (unlike walls or fences) and should not be shown as early as police station icon or a theater.

  3. This is not an outdoor map - we have plenty of them and I don't see they care for gates at all ( https://opentopomap.org/#map=16/46.36425/11.03320 , https://www.thunderforest.com/maps/outdoors/ ) and when they do, they skip many other POIs, selecting sustenance objects only ( http://www.hikebikemap.org/?zoom=15&lat=46.36352&lon=11.03347&layer=HikeBikeMap ).

  4. This is not a routing service. If somebody is planning a route, just an image on the map does not tell him if it's permanently open, closed or there are only some times when one can pass. I'm thinking about adding some basic access rendering too, but it will not suffice. I also think that mappers could use more access tags for roads, which would make it more evident if a given part is available or not than just a barrier node.

@kocio-pl kocio-pl merged commit 32a1193 into gravitystorm:master Apr 30, 2018
@kocio-pl kocio-pl deleted the barriers-later branch April 30, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants